Repository navigation
feat(ui): edit a panel's SQL in place - #344
Merged
Merged
Conversation
Panels defined by SQL gain "Edit SQL" for people allowed to edit the dashboard. A reusable CodeMirror 6 editor offers SQL highlighting, completion of the approved relations and their columns, and the server's validation problems inline. Mod-Enter runs the edited panel through the existing execution path and renders it with the panel renderer; Save writes only the SQL as a new dashboard version, and Cancel discards it. Escape leaves the editor without closing the dialog, closing with unsaved changes asks first, and version conflicts keep the draft. The editor loads as its own chunk, so dashboards that never edit do not download it. CodeMirror packages are pinned and their notices included. Claude-Session: https://claude.ai/code/session_018HfyEXHyGD1utmKF4CQtyQ
vishr
force-pushed
the
fix/panel-sql-editor
branch
from
October 18, 2026 02:15
dea036d to
853e1ef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SqlEditor: SQL highlighting, completion of approved relations and columns, server validation problems inline, Mod-Enter to run, Escape to leave the editor. It loads as its own chunk.Verification
just ui,just ui-check,just ui-deadcode.e2e/panel-sql-editor.spec.tsande2e/accessibility.spec.ts, 32 passed; contrast proven at 4.5:1 or better in both themes with the rule enabled.just checkin the pre-push hook.