Repository navigation
fix(mcp): answer unknown service names with the services that exist - #341
Merged
Merged
Conversation
An investigation on the OpenTelemetry Demo asked get_service_performance for "kafka", which is a messaging system, not a span service. All four panels came back empty and chat showed an empty view, so the agent moved on without the evidence it wanted. Service-scoped tools still run exactly as before. Only when a service was given and every result is empty does the tool check whether the service is retained in the clamped window. An unknown name returns unknown_service with up to ten known services by traffic and, when the name is a messaging system, database or peer, the services that use it. Known services with no matching rows keep their empty results. Valid calls perform no membership lookup (measured at no added latency); guidance is bounded so the in-process agent never truncates it. Claude-Session: https://claude.ai/code/session_018HfyEXHyGD1utmKF4CQtyQ
vishr
force-pushed
the
fix/agent-service-input
branch
from
October 18, 2026 01:35
159f6d3 to
6e6a19b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_service_performanceforkafka, a messaging system rather than a span service. Every panel came back empty and chat showed an empty view.get_service_performance,get_service_dependencies,search_logs,inspect_trace) run exactly as before. Only when a service was given and every result is empty does the tool check whether the service is retained in the clamped window. An unknown name returnsunknown_servicewith up to ten known services by traffic and, for a messaging system, database or peer, the services that use it.Verification
ToolRegistry.Execute), and zero membership lookups on populated calls.go testandgo test -raceoninternal/mcp,internal/agent,internal/panel;just docs-generate-check; two Codex adversarial reviews.just checkin the pre-push hook.