Repository navigation
refactor(api): serve alerts and their summary under the alerting domain - #338
Merged
Merged
Conversation
One feature used two path domains: fired alerts at /api/alerts and /api/alerts/summary, rules at /api/alerting/rules. Alerts and the summary now live beside the rules, so every alerting route shares one domain and no sibling resource sits where an alert ID would belong. - GET /api/alerting/alerts lists fired alerts. - GET /api/alerting/summary returns the summary view. - The old /api/alerts routes are removed, with no aliases. Responses are unchanged. Authorization classification, tests, the route reference and the alerts guide move with the routes. Claude-Session: https://claude.ai/code/session_018HfyEXHyGD1utmKF4CQtyQ
vishr
force-pushed
the
fix/alerting-routes
branch
from
October 17, 2026 21:32
4d8811f to
e685e6f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
One feature used two path domains: fired alerts at
/api/alertsand/api/alerts/summary, rules at/api/alerting/rules. Everything now shares thealertingdomain, and no sibling resource sits where an alert ID would belong.GET /api/alertsGET /api/alerting/alertsGET /api/alerts/summaryGET /api/alerting/summary/api/alerting/rules…The old routes are removed with no aliases (breaking for direct API callers). Responses are unchanged. Authorization classification, tests, the generated route reference and the alerts guide move with the routes.
Verification
go test ./internal/api/... ./internal/alert/... ./cmd/fanout-docgen/...,go vet ./internal/api/..., UI lint and auth/router tests.just docs-generate-check; no remaining product references to/api/alerts.just checkin the pre-push hook.