Skip to content

refactor(api): serve alerts and their summary under the alerting domain - #338

Merged
vishr merged 1 commit into
mainfrom
fix/alerting-routes
Oct 17, 2026
Merged

vishr merged 1 commit into
mainfrom
fix/alerting-routes

Conversation

@vishr

@vishr vishr commented Oct 17, 2026 •

Copy link
Copy Markdown
Member

Summary

One feature used two path domains: fired alerts at /api/alerts and /api/alerts/summary, rules at /api/alerting/rules. Everything now shares the alerting domain, and no sibling resource sits where an alert ID would belong.

Old New
GET /api/alerts GET /api/alerting/alerts
GET /api/alerts/summary GET /api/alerting/summary
/api/alerting/rules… unchanged

The old routes are removed with no aliases (breaking for direct API callers). Responses are unchanged. Authorization classification, tests, the generated route reference and the alerts guide move with the routes.

Verification

  • go test ./internal/api/... ./internal/alert/... ./cmd/fanout-docgen/..., go vet ./internal/api/..., UI lint and auth/router tests.
  • just docs-generate-check; no remaining product references to /api/alerts.
  • just check in the pre-push hook.

One feature used two path domains: fired alerts at /api/alerts and
/api/alerts/summary, rules at /api/alerting/rules. Alerts and the
summary now live beside the rules, so every alerting route shares one
domain and no sibling resource sits where an alert ID would belong.

- GET /api/alerting/alerts lists fired alerts.
- GET /api/alerting/summary returns the summary view.
- The old /api/alerts routes are removed, with no aliases.

Responses are unchanged. Authorization classification, tests, the route
reference and the alerts guide move with the routes.

Claude-Session: https://claude.ai/code/session_018HfyEXHyGD1utmKF4CQtyQ
@vishr
vishr force-pushed the fix/alerting-routes branch from 4d8811f to e685e6f Compare October 17, 2026 21:32
@vishr
vishr merged commit fbfc8cb into main Oct 17, 2026
16 checks passed
@vishr
vishr deleted the fix/alerting-routes branch October 17, 2026 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant