Repository navigation
fix(mcp): show slow operations for every protocol in service performance - #335
Merged
Merged
Conversation
The service performance preset grouped its slow-endpoint table by http_route and kept only rows with a route. gRPC servers and message consumers have no HTTP route, so for services such as checkout and fraud-detection in the OpenTelemetry Demo the panel was always empty, and chat opened it as a large empty box. The panel is now "Slow operations": p95 duration by operation over the spans a service handles (server and consumer spans). HTTP, gRPC and consumer spans each name the operation, so one query covers all three. When several filters combine to match nothing, the empty-state diagnosis now names the combination instead of blaming one filter that matches rows on its own. Claude-Session: https://claude.ai/code/session_018HfyEXHyGD1utmKF4CQtyQ
vishr
force-pushed
the
fix/performance-operations
branch
from
October 17, 2026 18:51
59e8177 to
434a85f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
http_routeand kept only rows with a route. gRPC servers and message consumers have no HTTP route, so for services such as checkout and fraud-detection in the OpenTelemetry Demo the panel was always empty, and chat opened it as a large empty box.operationover server and consumer spans. HTTP, gRPC and consumer spans each name the operation, so one query covers all three.Verification
go test ./internal/mcp/... ./internal/panel/... ./internal/agent/..., UI lint and affected UI tests,just docs-generate-check.just checkin the pre-push hook.