Repository navigation
fix(ui): size chart axes by data and keep table values whole - #325
Merged
Merged
Conversation
- Thresholds were included in the y-axis extent, so a 2 s "bad" line on p95 latency stretched the axis to 2 s and flattened 20 ms series onto the floor. Axes now follow the data; a threshold outside the data's range is not drawn, and the panel's status badge still reports it. - Threshold labels sit inside the end of the line, facing into the plot, so they cannot collide with the axis tick labels. - Dashboard tables used table-layout: fixed, which split widths evenly and let a nowrap timestamp overlap the next column. Tables now size columns by content: timestamps, numbers and badges stay whole, free text ellipsizes with its full value in the title, and a table that does not fit scrolls horizontally. Claude-Session: https://claude.ai/code/session_01XA52nWyQ3R5f5kK8kjpAQW
vishr
force-pushed
the
fix/overview-charts
branch
from
October 16, 2026 20:34
e865e00 to
ce72048
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three presentation defects on the default System overview with OpenTelemetry Demo data, at 1440 px in both themes:
Threshold flattened the series. Thresholds were part of the y-axis extent. p95 latency's 2 s "bad" line stretched the axis to 2 s, so every 20 ms series lay on the floor. Axes now follow the data. A threshold outside the data's range is not drawn, and the panel's status badge still reports the state.
Threshold label beside the ticks. Labels sit inside the end of the line, facing into the plot, so they cannot collide with axis tick labels.
Table text overlap.
.dashboard-tableusedtable-layout: fixed, which split widths evenly regardless of content. A nowrap timestamp then overlapped the next column. Columns now size by content:The fixed widths for logs, traces and log patterns are kept as minimums.
Verification
just ui-lint,just ui-test(1,319 tests),just ui-check: passed.just check(pre-push): passed.