Skip to content

fix(ui): size chart axes by data and keep table values whole - #325

Merged
vishr merged 1 commit into
mainfrom
fix/overview-charts
Oct 16, 2026
Merged

vishr merged 1 commit into
mainfrom
fix/overview-charts

Conversation

@vishr

@vishr vishr commented Oct 16, 2026 •

Copy link
Copy Markdown
Member

Summary

Three presentation defects on the default System overview with OpenTelemetry Demo data, at 1440 px in both themes:

  • Threshold flattened the series. Thresholds were part of the y-axis extent. p95 latency's 2 s "bad" line stretched the axis to 2 s, so every 20 ms series lay on the floor. Axes now follow the data. A threshold outside the data's range is not drawn, and the panel's status badge still reports the state.

  • Threshold label beside the ticks. Labels sit inside the end of the line, facing into the plot, so they cannot collide with axis tick labels.

  • Table text overlap. .dashboard-table used table-layout: fixed, which split widths evenly regardless of content. A nowrap timestamp then overlapped the next column. Columns now size by content:

    • timestamps, numbers and badges stay whole;
    • free text ellipsizes, with the full value in the title and a 14ch minimum;
    • a table that does not fit scrolls horizontally.

    The fixed widths for logs, traces and log patterns are kept as minimums.

Verification

  • Checked in Chrome against a server built from this branch, using a one-hour OpenTelemetry Demo snapshot: p95 latency, requests, hosts and containers panels in both themes.
  • just ui-lint, just ui-test (1,319 tests), just ui-check: passed.
  • just check (pre-push): passed.

- Thresholds were included in the y-axis extent, so a 2 s "bad" line on
  p95 latency stretched the axis to 2 s and flattened 20 ms series onto the
  floor. Axes now follow the data; a threshold outside the data's range is
  not drawn, and the panel's status badge still reports it.
- Threshold labels sit inside the end of the line, facing into the plot, so
  they cannot collide with the axis tick labels.
- Dashboard tables used table-layout: fixed, which split widths evenly and
  let a nowrap timestamp overlap the next column. Tables now size columns
  by content: timestamps, numbers and badges stay whole, free text
  ellipsizes with its full value in the title, and a table that does not
  fit scrolls horizontally.

Claude-Session: https://claude.ai/code/session_01XA52nWyQ3R5f5kK8kjpAQW
@vishr
vishr force-pushed the fix/overview-charts branch from e865e00 to ce72048 Compare October 16, 2026 20:34
@vishr
vishr merged commit 0667bbd into main Oct 16, 2026
14 checks passed
@vishr
vishr deleted the fix/overview-charts branch October 16, 2026 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant