Repository navigation
fix(intelligence): require a meaningful change before reporting latency and volume anomalies - #324
Merged
Merged
Conversation
…cy and volume anomalies Latency and volume anomalies fired on the z-score alone. The baseline is the scatter of a few five-minute buckets, so a steady service has a tiny standard deviation and a 0.1 ms or 5% shift scored as a severe anomaly. One hour of the OpenTelemetry Demo produced 36 findings across 18 services, and the dashboard's anomaly overlay covered every panel for the whole hour. Both checks now also need practical significance, in the style of the existing error-rate floor: - latency: p95 must rise by at least 20% and at least 5 ms, with a 1 ms floor on the baseline scatter; - volume: the count must change by at least 25% in either direction, with a one-span floor on the scatter. A service present in the baseline but silent now is evaluated, so traffic stopping is reported. Only qualified findings affect severity, insights and the health score. Replaying the detector over one hour of a Demo snapshot reduced findings from 87 to 2; the remaining one is a frontend-web p95 rise from 202 to 243 ms. Claude-Session: https://claude.ai/code/session_01XA52nWyQ3R5f5kK8kjpAQW
vishr
force-pushed
the
fix/detector-effect-size
branch
from
October 16, 2026 20:15
95acb6d to
ad7cb2c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Latency and volume anomalies fired on the z-score alone. The baseline is the scatter of a few five-minute buckets, so a steady service has a tiny standard deviation, and a 0.1 ms or 5% shift scored as a severe anomaly. One hour of the OpenTelemetry Demo produced 36 findings across 18 services. Examples:
ad P95 latency: 1.4ms (baseline 1.3ms, z-score 3.15)payment volume: 263 spans (baseline 250, z-score 3.52)As a result, the dashboard's anomaly overlay covered every panel for the whole hour.
Both checks now also need practical significance, in the style of the existing error-rate floor (
minErrorRateStddev):Only qualified findings affect severity, insights and the health score. No storage, API or format changes.
Evidence
Replayed 60 detector evaluations over one hour of an OpenTelemetry Demo snapshot (rollups rebuilt with the repository's refresh code):
The one remaining episode is a
frontend-webp95 rise from 202 to 243 ms.New tests cover:
Verification
go test ./internal/intelligence/... ./internal/alert/... ./internal/annotations/...: passed.just check(pre-push): passed.