Skip to content

fix: account for every offered read operation in benchmarks - #13

Merged
vishr merged 1 commit into
mainfrom
fix/read-load-accounting
Nov 15, 2026
Merged

vishr merged 1 commit into
mainfrom
fix/read-load-accounting

Conversation

@vishr

@vishr vishr commented Nov 14, 2026 •

Copy link
Copy Markdown
Member

Summary

Companion product changes: labstack/pitot#473

Read reports can hide scheduler misses and queue delay, and count drain completions toward the offered load. Account for every scheduled arrival and qualify reads using completion time from the scheduled arrival.

offered arrivals
  → scheduler misses / shed / dispatched
  → dispatched queue + HTTP operation
  → success during load / success during drain / failure / cancellation

Report intended and performed operation kinds, including fallback attribution. Add the proposed interactive-http-draft/v1 per-kind p95/p99 profile to workload metadata and qualification. Preserve historical service-time fields; legacy and undersampled reports cannot qualify against the new profile.

Evidence

  • Before: ticker losses and scheduler queue time were absent from read evidence; drain completions could increase reported goodput.
    After: tests reconcile every offered/dispatched outcome, delayed scheduling, fallback mix, queue and completion latency, phase cutoff/drain, profile matching, and the 1,000-successful-samples-per-kind gate.
  • Passed go test ./..., go test -race ./..., go vet ./..., and staged secret scanning.
  • No new production capacity result is claimed. HTTP completion remains separate from browser paint.

Merge Danger

Door: two-way

New read qualification is intentionally stricter. Standard short sweeps may use the documented best-completion topology fallback because they cannot provide enough p99 samples. Published measurements are not rewritten.

Blast Radius: reporting

Changes read-load scheduling, mixed-topology eligibility, report metadata and qualification; ingest measurement is unchanged.

@vishr
vishr merged commit 349fd4c into main Nov 15, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant