fix(e2e): count kept volumes by owner label, not by name - #210
Merged
Merged
Conversation
Volumes no longer carry the application's name, so grepping `docker volume ls` for observer found nothing and "destroy without volumes keeps the data" failed on a destroy that had kept them. Count the volumes labelled onebox.app=observer instead. This failed the v2026.9.14 release's server suite before anything was published.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Volumes no longer carry the application's name, so grepping
docker volume lsfor observer found nothing and "destroy without volumes keepsthe data" failed on a destroy that had kept them. Count the volumes
labelled onebox.app=observer instead. This failed the v2026.9.14
release's server suite before anything was published.