Skip to content

Retry stapling when Apple's ticket service drops the connection - #46

Merged
vishr merged 2 commits into
mainfrom
fix/staple-retry
Oct 23, 2026
Merged

vishr merged 2 commits into
mainfrom
fix/staple-retry

Conversation

@vishr

@vishr vishr commented Oct 23, 2026

Copy link
Copy Markdown
Member

v2026.10.10-alpha was notarized for both macOS builds, then xcrun stapler staple failed twice on the GitHub runner with NSURLErrorDomain -1005 ("The network connection was lost") while fetching the ticket from api.apple-cloudkit.com. The same endpoint answered normally from a local Mac.

Stapling now retries up to five times, 30 s apart. stapler validate, codesign --verify and spctl --assess still run afterwards, so an unstapled app still fails the build.

This PR touches scripts/build-macos-app.sh, so the macOS signing workflow runs the real sign, notarize and staple path here before merge.

vishr added 2 commits October 23, 2026 12:20
…nnection

v2026.10.10-alpha notarized both macOS builds, then stapler failed twice
with NSURLErrorDomain -1005 fetching the ticket. Stapling now retries up
to five times, 30 s apart; validation and Gatekeeper checks are unchanged.
stapler validate also fetches the ticket and failed with -1005 after a
retried staple succeeded on the signing check.
@vishr
vishr merged commit 01e42bd into main Oct 23, 2026
5 checks passed
@vishr
vishr deleted the fix/staple-retry branch October 23, 2026 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant