Skip to content

fix: sign Driga.app on the runner and check signing without a release - #42

Merged
vishr merged 2 commits into
mainfrom
ci/macos-signing-check
Oct 22, 2026
Merged

vishr merged 2 commits into
mainfrom
ci/macos-signing-check

Conversation

@vishr

@vishr vishr commented Oct 22, 2026 •

Copy link
Copy Markdown
Member

Two releases (v2026.10.6, v2026.10.7) failed in the macOS signing hook with error: The specified item could not be found in the keychain.

Root cause

The new signing check showed the Developer ID identity valid inside the temporary keychain (1 valid identities found) while the user search list held only login.keychain-db (default search: 0 valid identities found). On hosted runners codesign resolves the identity through the search list even with --keychain.

What changed

  • scripts/macos-signing-keychain.sh puts the temporary keychain ahead of the existing ones on the user search list; delete-keychain in the cleanup step removes it again.
  • New macOS signing workflow: runs the release's keychain setup, codesign, notarization, stapling and Gatekeeper check on macos-15 for a freshly built Driga.app, without publishing. Runs on workflow_dispatch and same-repository PRs touching the signing files (no secrets for forks).

Verified

The signing check on this PR: signed by Developer ID Application: LabStack LLC (PXLH8G9D76), notarization Accepted / Ready for distribution, stapled, Gatekeeper accepted, source=Notarized Developer ID.

https://claude.ai/code/session_01LgBKAoFnRMD24bTnkRvNau

vishr added 2 commits October 22, 2026 09:48
Runs the release's keychain setup, codesign, notarization and stapling on
macos-15 for changes to the signing scripts, so a signing fix is proven
before a release tag is used.

Claude-Session: https://claude.ai/code/session_01LgBKAoFnRMD24bTnkRvNau
The signing check showed the Developer ID identity valid inside the
temporary keychain while the user search list held only login.keychain;
codesign then failed with "The specified item could not be found in the
keychain" even with --keychain. Add the keychain ahead of the existing
ones; delete-keychain in the cleanup step removes it again.

Claude-Session: https://claude.ai/code/session_01LgBKAoFnRMD24bTnkRvNau
@vishr vishr changed the title ci: check macOS app signing without publishing a release fix: sign Driga.app on the runner and check signing without a release Oct 22, 2026
@vishr
vishr enabled auto-merge (squash) October 22, 2026 16:56
@vishr
vishr merged commit bc9c7cc into main Oct 22, 2026
5 checks passed
@vishr
vishr deleted the ci/macos-signing-check branch October 22, 2026 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant