Repository navigation
fix: sign Driga.app on the runner and check signing without a release - #42
Merged
Merged
Conversation
Runs the release's keychain setup, codesign, notarization and stapling on macos-15 for changes to the signing scripts, so a signing fix is proven before a release tag is used. Claude-Session: https://claude.ai/code/session_01LgBKAoFnRMD24bTnkRvNau
The signing check showed the Developer ID identity valid inside the temporary keychain while the user search list held only login.keychain; codesign then failed with "The specified item could not be found in the keychain" even with --keychain. Add the keychain ahead of the existing ones; delete-keychain in the cleanup step removes it again. Claude-Session: https://claude.ai/code/session_01LgBKAoFnRMD24bTnkRvNau
vishr
enabled auto-merge (squash)
October 22, 2026 16:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two releases (
v2026.10.6,v2026.10.7) failed in the macOS signing hook witherror: The specified item could not be found in the keychain.Root cause
The new signing check showed the Developer ID identity valid inside the temporary keychain (
1 valid identities found) while the user search list held onlylogin.keychain-db(default search:0 valid identities found). On hosted runnerscodesignresolves the identity through the search list even with--keychain.What changed
scripts/macos-signing-keychain.shputs the temporary keychain ahead of the existing ones on the user search list;delete-keychainin the cleanup step removes it again.macos-15for a freshly builtDriga.app, without publishing. Runs on workflow_dispatch and same-repository PRs touching the signing files (no secrets for forks).Verified
The signing check on this PR: signed by
Developer ID Application: LabStack LLC (PXLH8G9D76), notarizationAccepted/Ready for distribution, stapled, Gatekeeperaccepted, source=Notarized Developer ID.https://claude.ai/code/session_01LgBKAoFnRMD24bTnkRvNau