Don't error if 'data' group already exists#117
Open
chrisjbillington wants to merge 1 commit intolabscript-suite:masterfrom
Open
Don't error if 'data' group already exists#117chrisjbillington wants to merge 1 commit intolabscript-suite:masterfrom
chrisjbillington wants to merge 1 commit intolabscript-suite:masterfrom
Conversation
This allows e.g. FunctionRunner functions to save data acquired at the start of a shot during transition_to_buffered, which is less awkward than trying to stash it somewhere and arrange to save it during transition_to_manual.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows e.g. FunctionRunner functions to save data acquired at the start of a shot during transition_to_buffered, which is less awkward than trying to stash it somewhere and arrange to save it during transition_to_manual.
We do some measurements at the start of a shot that are essentially logging the state of things when the shot ran. It makes sense to simply save them when they're measured instead of jumping through hoops to save them later.