fix(eaglercraft-server): drop the invalid WS backend-protocol annotation - #759
Merged
zjy365 merged 1 commit intoSep 9, 2026
Merged
Conversation
ingress-nginx does not accept `WS` as a `backend-protocol` value, and the WebSocket upgrade on port 5200 works without it. The annotation only marked port 5200 as WebSocket-only for the platform, which hid the browser client page behind a copy-only `wss://` address. Port 5200 serves the client over HTTP and upgrades the same path, so it is an HTTP port. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01K5m7FUKCppYpMxKwHxrPgV
aimeritething
force-pushed
the
fix/eaglercraft-ws-marker
branch
from
September 9, 2026 02:23
21f04b0 to
f5e5c1d
Compare
aimeritething
changed the title
zjy365
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #758.
What
Removes
nginx.ingress.kubernetes.io/backend-protocol: WSfrom the game Ingress. ingress-nginx does not acceptWSas a value and the WebSocket upgrade on port 5200 works without it. The annotation only marked port 5200 as WebSocket-only for the platform, which hid the browser client page behind a copy-onlywss://address. Port 5200 serves the client over HTTP and upgrades the same path, so it is an HTTP port.The explicit
/admin.css,/admin.js,/admin-i18n.jspaths on the console Ingress are unchanged. That path set was validated live in #717 and #748.Verification
python scripts/test_eaglercraft_runtime_refresh.py→ PASSindex.yamlparses; the game Ingress carries nobackend-protocolannotation; the console path list is unchanged.Related
spec.entriesfrom feat(eaglercraft-server): declare open and share entries in the Template spec #758.shareback to the plain root URL.🤖 Generated with Claude Code
https://claude.ai/code/session_01K5m7FUKCppYpMxKwHxrPgV