Skip to content

Merge stabilisation GCR hotfixes into petri #755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tcsenpai merged 12 commits into from
Apr 2, 2026

fix: update omni gcr handler to new in-memory GCR API + gitignore mer…

aa7663e
Select commit
Loading
Failed to load commit list.
Merged

Merge stabilisation GCR hotfixes into petri #755

fix: update omni gcr handler to new in-memory GCR API + gitignore mer…
aa7663e
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Apr 2, 2026 in 1m 18s

Quality Gate passed

Issues
32 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Annotations

Check failure on line 42 in src/libs/network/endpointExecution.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 67 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZ1O-pT3ThPYW9y3bYIH&open=AZ1O-pT3ThPYW9y3bYIH&pullRequest=755

Check warning on line 817 in src/libs/blockchain/gcr/handleGCR.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this commented out code. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZ1O-pVfThPYW9y3bYIZ&open=AZ1O-pVfThPYW9y3bYIZ&pullRequest=755

Check warning on line 1092 in src/libs/blockchain/gcr/handleGCR.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unexpected negated condition. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZ1O-pVfThPYW9y3bYId&open=AZ1O-pVfThPYW9y3bYId&pullRequest=755

Check failure on line 332 in src/libs/blockchain/gcr/handleGCR.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 18 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZ1O-pVfThPYW9y3bYIP&open=AZ1O-pVfThPYW9y3bYIP&pullRequest=755

Check warning on line 517 in src/libs/blockchain/gcr/handleGCR.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

'error' will use Object's default stringification format ('[object Object]') when stringified. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZ1O-pVfThPYW9y3bYIT&open=AZ1O-pVfThPYW9y3bYIT&pullRequest=755

Check failure on line 395 in src/libs/blockchain/gcr/handleGCR.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 37 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZ1O-pVfThPYW9y3bYIQ&open=AZ1O-pVfThPYW9y3bYIQ&pullRequest=755

Check warning on line 951 in src/libs/omniprotocol/transport/PeerConnection.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this commented out code. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZ1O-paPThPYW9y3bYIg&open=AZ1O-paPThPYW9y3bYIg&pullRequest=755

Check warning on line 31 in src/libs/consensus/v2/PoRBFT.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused import of 'forgeToHex'. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZ1O-pUvThPYW9y3bYIJ&open=AZ1O-pUvThPYW9y3bYIJ&pullRequest=755

Check warning on line 135 in src/libs/blockchain/gcr/handleGCR.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make this public static property readonly. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZ1O-pVfThPYW9y3bYIM&open=AZ1O-pVfThPYW9y3bYIM&pullRequest=755

Check warning on line 47 in src/libs/blockchain/gcr/gcr_routines/routines/ethosRoutines.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Handle this exception or don't catch it at all. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZ1O-pWRThPYW9y3bYIe&open=AZ1O-pWRThPYW9y3bYIe&pullRequest=755

Check warning on line 795 in src/libs/blockchain/gcr/handleGCR.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this commented out code. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZ1O-pVfThPYW9y3bYIX&open=AZ1O-pVfThPYW9y3bYIX&pullRequest=755

Check warning on line 582 in src/libs/l2ps/L2PSConsensus.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this commented out code. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZ1O-pcNThPYW9y3bYIl&open=AZ1O-pcNThPYW9y3bYIl&pullRequest=755

Check warning on line 568 in src/libs/l2ps/L2PSConsensus.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this commented out code. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZ1O-pcNThPYW9y3bYIk&open=AZ1O-pcNThPYW9y3bYIk&pullRequest=755

Check warning on line 751 in src/libs/blockchain/gcr/handleGCR.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this commented out code. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZ1O-pVfThPYW9y3bYIV&open=AZ1O-pVfThPYW9y3bYIV&pullRequest=755

Check warning on line 238 in src/libs/network/endpointExecution.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

'e' will use Object's default stringification format ('[object Object]') when stringified. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZ1O-pT3ThPYW9y3bYII&open=AZ1O-pT3ThPYW9y3bYII&pullRequest=755

Check warning on line 32 in src/libs/consensus/v2/PoRBFT.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused import of 'dataSource'. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZ1O-pUvThPYW9y3bYIL&open=AZ1O-pUvThPYW9y3bYIL&pullRequest=755

Check warning on line 53 in src/libs/blockchain/gcr/gcr_routines/GCRBalanceRoutines.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this commented out code. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZ1O-pXsThPYW9y3bYIf&open=AZ1O-pXsThPYW9y3bYIf&pullRequest=755

Check warning on line 820 in src/libs/blockchain/gcr/handleGCR.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this commented out code. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZ1O-pVfThPYW9y3bYIa&open=AZ1O-pVfThPYW9y3bYIa&pullRequest=755

Check warning on line 291 in src/libs/l2ps/L2PSConsensus.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this commented out code. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZ1O-pcNThPYW9y3bYIi&open=AZ1O-pcNThPYW9y3bYIi&pullRequest=755

Check warning on line 32 in src/libs/consensus/v2/PoRBFT.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused import of 'Datasource'. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZ1O-pUvThPYW9y3bYIK&open=AZ1O-pUvThPYW9y3bYIK&pullRequest=755

Check warning on line 304 in src/libs/blockchain/gcr/handleGCR.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `String#replaceAll()` over `String#replace()`. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZ1O-pVfThPYW9y3bYIN&open=AZ1O-pVfThPYW9y3bYIN&pullRequest=755

Check warning on line 466 in src/libs/blockchain/gcr/handleGCR.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

'error' will use Object's default stringification format ('[object Object]') when stringified. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZ1O-pVfThPYW9y3bYIS&open=AZ1O-pVfThPYW9y3bYIS&pullRequest=755

Check warning on line 788 in src/libs/blockchain/gcr/handleGCR.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this commented out code. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZ1O-pVfThPYW9y3bYIW&open=AZ1O-pVfThPYW9y3bYIW&pullRequest=755

Check warning on line 306 in src/libs/blockchain/gcr/handleGCR.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `String#replaceAll()` over `String#replace()`. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZ1O-pVfThPYW9y3bYIO&open=AZ1O-pVfThPYW9y3bYIO&pullRequest=755

Check warning on line 279 in src/libs/l2ps/L2PSConsensus.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this commented out code. 

See more on https://sonarcloud.io/project/issues?id=kynesyslabs_node&issues=AZ1O-pcNThPYW9y3bYIh&open=AZ1O-pcNThPYW9y3bYIh&pullRequest=755
View more details on SonarQubeCloud