fix(keywords): extend the list of restricted names, with a test#21
Open
ceejbot wants to merge 2 commits into
Open
fix(keywords): extend the list of restricted names, with a test#21ceejbot wants to merge 2 commits into
ceejbot wants to merge 2 commits into
Conversation
I observed that the list of restricted words didn't cover some attractive words when I attempted to generate a Rust client for a schema that used keywords like `async` as field names. - Extended the list of names in `is_restricted()`. - Added a short yaml schema that uses all of the restricted words as field names. Put this fixture to work in a test, to ensure no regressions. The list is undoubtedly incomplete, but there is a very clear place to add new ones (thank you!) and now a test to validate it.
This is the right way to do it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I observed that the list of restricted words didn't cover some attractive words when I attempted to generate a Rust client for a schema that used keywords like
asyncas field names.is_restricted().The list is undoubtedly incomplete, but there is a very clear place to add new ones (thank you!) and now a test to validate it.
The whitespace changes in lib.rs are from my editor auto-applying
cargo fmtto the file.