Check all rust keywords, deal with recursive structs#15
Open
pscott31 wants to merge 2 commits into
Open
Conversation
This was referenced Nov 24, 2023
Owner
|
Can you add a regression test to this, or at least a minimal real-world OpenAPI spec that'd have such recursion. I'm not sure how you'd encounter this in an OpenAPI spec in the real world. struct Item{
name: String
related_item: Option<Item>
}is an illegal struct for the same reason (it'd have to be a The check_keyword is a great find, happy to merge that separately or when above question is addressed. EDIT: Nevermind, saw that you brought this up via Issue #12 |
Owner
|
Would you be able to trim down the vwphere spec to the offending endpoint or struct to facilitate adding a regression test? I think it's from |
ceejbot
added a commit
to ceejbot/libninja
that referenced
this pull request
Apr 4, 2024
This is the right way to do it.
ceejbot
added a commit
to ceejbot/libninja
that referenced
this pull request
Apr 4, 2024
This is the right way to do it.
ceejbot
added a commit
to ceejbot/libninja
that referenced
this pull request
Aug 6, 2024
This is the right way to do it.
ceejbot
added a commit
to ceejbot/libninja
that referenced
this pull request
Oct 3, 2024
This is the right way to do it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was using this to generate an API for Square; and they had a api method called 'break' which upset the generator; so I've added in a crate that purports to have an exhaustive list.
Secondly, they have calls where youve got something like
Which was causing the example generator to try and make an infinitely nested example. I had a go at refactoring
to_rust_example_valueto be iterative instead of recursive but gave up and instead pass around a set identifiers that we've already used in the tree to that point and put aNonethere instead ofSome<Item>.Might be nice to allow a couple one or two levels perhaps, we could change the HashSet into a HashMap with a depth - but thought I'd keep it simple.