Repository navigation
build: migrate project tooling to pnpm - #37
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
The developer wanted to fix a failing build without bypassing their pnpm security guardrails, remove the unused @vitest/browser dependency, and migrate the project fully from npm to pnpm so release-age and dependency-build-script protections remain active. They also wanted investigation of a failed release pipeline, learned it failed only at Chrome Web Store publishing due to an expired/invalid OAuth refresh token, and needed guidance reconstructing the SUBMIT_KEYS secret because GitHub would not reveal the existing value. After updating the secret, they wanted to know how to trigger publishing the already-created 0.1.10 release again, asking whether an empty commit was the right approach.
What Changed
pnpm-lock.yamland addspnpm-workspace.yamlso installs use the repository's pnpm guardrails.Risk Assessment
✅ Low: The changes are limited to package-manager migration, CI/release command substitutions, and documentation, with no material correctness or release risks identified in the reviewed diff.
Testing
Verified pnpm 11.5.0 with the release-age guardrail active, installed from the frozen pnpm lockfile with supply-chain policy verification, ran unit tests, built the Chrome extension, captured browser screenshots from an extension e2e run, packaged the built extension zip used by the release workflow, and ran the broader extension e2e suite; all local checks passed, with live Chrome Web Store publishing intentionally not attempted because it requires external credentials and mutates production state.
/var/folders/5x/4nqprlbx0518k3ybcb1sz6gr0000gn/T/no-mistakes-evidence/01KT2JCCZ7Z4GTZ61XKNB705XZ/button-control-avoided.png)/var/folders/5x/4nqprlbx0518k3ybcb1sz6gr0000gn/T/no-mistakes-evidence/01KT2JCCZ7Z4GTZ61XKNB705XZ/tabindex-container-not-avoided.png)Evidence: Browser placement measurement evidence
/var/folders/5x/4nqprlbx0518k3ybcb1sz6gr0000gn/T/no-mistakes-evidence/01KT2JCCZ7Z4GTZ61XKNB705XZ/simplewords.zip)Evidence: Frozen pnpm install supply-chain policy check
Evidence: Release zip contents
Pipeline
Updates from git push no-mistakes
✅ **intent** - passed
✅ No issues found.
✅ **Rebase** - passed
✅ No issues found.
✅ **Review** - passed
✅ No issues found.
.github/workflows/release-please.yml:61- I did not exercise the live Chrome Web Store publish step because this worktree does not have SUBMIT_KEYS and invoking the publish command with real credentials would mutate external Chrome Web Store state. Validation is limited to the pnpm-based build, release zip creation, and browser extension e2e behavior.pnpm --versionpnpm config get minimumReleaseAgepnpm install --frozen-lockfilepnpm testpnpm run buildpnpm exec playwright test e2e/button-overlap.spec.tszip -r ../simplewords.zip .fromextension/unzip -l simplewords.zippnpm exec playwright test e2e/extension.spec.ts✅ **Document** - passed
✅ No issues found.
✅ **Lint** - passed
✅ No issues found.
✅ **Push** - passed
✅ No issues found.