Skip to content

build: migrate project tooling to pnpm - #37

Merged
kunchenguid merged 2 commits into
mainfrom
chore/migrate-to-pnpm
Jun 1, 2026
Merged

kunchenguid merged 2 commits into
mainfrom
chore/migrate-to-pnpm

Conversation

@kunchenguid

Copy link
Copy Markdown
Owner

Intent

The developer wanted to fix a failing build without bypassing their pnpm security guardrails, remove the unused @vitest/browser dependency, and migrate the project fully from npm to pnpm so release-age and dependency-build-script protections remain active. They also wanted investigation of a failed release pipeline, learned it failed only at Chrome Web Store publishing due to an expired/invalid OAuth refresh token, and needed guidance reconstructing the SUBMIT_KEYS secret because GitHub would not reveal the existing value. After updating the secret, they wanted to know how to trigger publishing the already-created 0.1.10 release again, asking whether an empty commit was the right approach.

What Changed

  • Replaces npm lockfile usage with pnpm-lock.yaml and adds pnpm-workspace.yaml so installs use the repository's pnpm guardrails.
  • Updates package scripts, CI, and release workflows to run through pnpm, including the release build and zip packaging path.
  • Aligns project docs and agent guidance with the pnpm-based install, build, test, and marketing-video workflows.

Risk Assessment

✅ Low: The changes are limited to package-manager migration, CI/release command substitutions, and documentation, with no material correctness or release risks identified in the reviewed diff.

Testing

Verified pnpm 11.5.0 with the release-age guardrail active, installed from the frozen pnpm lockfile with supply-chain policy verification, ran unit tests, built the Chrome extension, captured browser screenshots from an extension e2e run, packaged the built extension zip used by the release workflow, and ran the broader extension e2e suite; all local checks passed, with live Chrome Web Store publishing intentionally not attempted because it requires external credentials and mutates production state.

  • Evidence: Simple Words button avoids page Send button (local file: /var/folders/5x/4nqprlbx0518k3ybcb1sz6gr0000gn/T/no-mistakes-evidence/01KT2JCCZ7Z4GTZ61XKNB705XZ/button-control-avoided.png)
  • Evidence: Simple Words button does not avoid broad tabindex wrapper (local file: /var/folders/5x/4nqprlbx0518k3ybcb1sz6gr0000gn/T/no-mistakes-evidence/01KT2JCCZ7Z4GTZ61XKNB705XZ/tabindex-container-not-avoided.png)
Evidence: Browser placement measurement evidence
{
  "buttonControlEvidence": {
    "editor": {
      "top": 161,
      "left": 80,
      "right": 280,
      "bottom": 261,
      "width": 200,
      "height": 100
    },
    "avoidTarget": {
      "top": 221,
      "left": 240,
      "right": 290,
      "bottom": 271,
      "width": 50,
      "height": 50
    },
    "simpleWordsButton": {
      "top": 169,
      "left": 248,
      "right": 272,
      "bottom": 193,
      "width": 24,
      "height": 24
    },
    "overlapsAvoidTarget": false
  },
  "tabindexEvidence": {
    "editor": {
      "top": 161,
      "left": 80,
      "right": 280,
      "bottom": 261,
      "width": 200,
      "height": 100
    },
    "avoidTarget": {
      "top": 221,
      "left": 240,
      "right": 290,
      "bottom": 271,
      "width": 50,
      "height": 50
    },
    "simpleWordsButton": {
      "top": 229,
      "left": 248,
      "right": 272,
      "bottom": 253,
      "width": 24,
      "height": 24
    },
    "overlapsAvoidTarget": true
  }
}
- Evidence: Packaged release zip (local file: /var/folders/5x/4nqprlbx0518k3ybcb1sz6gr0000gn/T/no-mistakes-evidence/01KT2JCCZ7Z4GTZ61XKNB705XZ/simplewords.zip)
Evidence: Frozen pnpm install supply-chain policy check
? Verifying lockfile against supply-chain policies (248 entries)...
✓ Lockfile passes supply-chain policies (248 entries in 1.9s)
Lockfile is up to date, resolution step is skipped
Done in 3s using pnpm v11.5.0
Evidence: Release zip contents
Archive: simplewords.zip
Included built extension files: background.js, content.js, options.js, manifest.json, options.html, and _locales/*/messages.json (26 files total).
- Outcome: ⚠️ 1 warning across 1 run (3m11s)

Pipeline

Updates from git push no-mistakes

✅ **intent** - passed

✅ No issues found.

✅ **Rebase** - passed

✅ No issues found.

✅ **Review** - passed

✅ No issues found.

⚠️ **Test** - 1 warning
  • ⚠️ .github/workflows/release-please.yml:61 - I did not exercise the live Chrome Web Store publish step because this worktree does not have SUBMIT_KEYS and invoking the publish command with real credentials would mutate external Chrome Web Store state. Validation is limited to the pnpm-based build, release zip creation, and browser extension e2e behavior.
  • pnpm --version
  • pnpm config get minimumReleaseAge
  • pnpm install --frozen-lockfile
  • pnpm test
  • pnpm run build
  • pnpm exec playwright test e2e/button-overlap.spec.ts
  • zip -r ../simplewords.zip . from extension/
  • unzip -l simplewords.zip
  • pnpm exec playwright test e2e/extension.spec.ts
✅ **Document** - passed

✅ No issues found.

✅ **Lint** - passed

✅ No issues found.

✅ **Push** - passed

✅ No issues found.

@kunchenguid
kunchenguid merged commit 27b339b into main Jun 1, 2026
1 check passed
@kunchenguid
kunchenguid deleted the chore/migrate-to-pnpm branch June 1, 2026 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant