fix: use evidence-based primary scope detection - #1892
Open
vipentti wants to merge 4 commits into
Open
Conversation
…nal focused verification
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
Prepare the upstream PR for issue #1809 , OpenCode linked-worktree supervision: use evidence-based primary detection instead of gitDir==commonDir. Rebase the recorded fork branch onto latest upstream main, preserve only the evidence-based predicate changes, the once-only not-primary diagnostic, and their direct callers, tests, and docs. Validate with the focused primary-scope coverage in tests/fm-turnend-guard.test.sh, tests/fm-pi-watch-extension.test.sh, shell lint on changed bin scripts, and documentation checks. Run the full no-mistakes flow with CI intentionally skipped under standing project policy, then push to the fork and open the upstream PR against kunchenguid/firstmate. Do not merge or push the default branch. Keep the validator agent and its codex/gpt-5.6-luna configuration unchanged; do not change no-mistakes configuration or shared daemon. Preserve SSH-signed commits under Ville Penttinen captain identity with no co-author trailers, AI attribution, machine-specific paths, hostnames, account IDs, or incident task names.
What Changed
--prelockhandling for session-start callers and inherited-home rejection for child worktrees.Pipeline
Updates from git push no-mistakes
✅ **intent** - passed
✅ **Rebase** - passed
✅ **Review** - completed
✅ **Test** - passed
✅ **Document** - passed
✅ **Lint** - passed
✅ **Push** - passed