fix(brief): start no-mistakes without firstmate handoff - #1840
Open
guanchengh-lgtm wants to merge 1 commit into
Open
fix(brief): start no-mistakes without firstmate handoff#1840guanchengh-lgtm wants to merge 1 commit into
guanchengh-lgtm wants to merge 1 commit into
Conversation
Author
|
Captain approved workflows for 0ca94fb; firstmate rechecking CI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
Collapse the no-mistakes ship brief two-phase handoff in Firstmate shared tracked material. Update bin/fm-brief.sh no-mistakes Definition of done so that after implementation is committed on fm/, the worker immediately starts no-mistakes axi run with a proper --intent and does not stop or wait for firstmate. Intermediate status may use working: starting no-mistakes, and there must be no terminal done: before CI is green; final remains done: PR {url} checks green only after no-mistakes reports CI green. Preserve ask-user escalation, the prohibition on --yes, the intent-contract rules, and all other safety text. Update tests/fm-brief.test.sh by replacing the old Firstmate-will-instruct assertion and adding generated-brief assertions for self-start behavior. Edit AGENTS.md only if it contradicts the brief; otherwise leave it unchanged, with firstmate retaining backup re-steer for a stalled worker. Do not change direct-PR or local-only behavior beyond necessary consistency. The implementation worker must be Codex gpt-5.6-sol at xhigh reasoning, must review a short plan covering files, DOD wording, test assertions, and AGENTS.md before implementation, and must self-review that plan for ask-user safety, no --yes, intent preservation, and no premature terminal done. Drive the full no-mistakes review, test, docs, lint, push, PR, and CI pipeline to a green PR. Do not merge the PR.
What Changed
bin/fm-brief.shso that after implementation is committed onfm/<id>, the worker immediately runsno-mistakes axi run --intent "..."instead of stopping for a Firstmate handoff.working: starting no-mistakesand forbid a terminaldone:before CI is green.tests/fm-brief.test.shand add generated-brief checks for self-start wording and nonterminal transition status.Risk Assessment
✅ Low: Minimal, intent-aligned wording change to the no-mistakes DOD plus matching generated-brief assertions; safety text and other ship modes are preserved.
Testing
Ran the focused fm-brief suite successfully, generated live no-mistakes/direct-PR/local-only briefs, and captured before/after Definition of done plus behavioral checks showing self-start axi run, nonterminal working status, preserved ask-user/--yes/intent safety text, no premature terminal done, and unchanged faster paths.
Evidence: Before/after no-mistakes Definition of done
Evidence: Generated no-mistakes brief (full)
Evidence: Generated no-mistakes DOD excerpt
Evidence: Generated direct-PR DOD (unchanged faster path)
Evidence: Generated local-only DOD (unchanged faster path)
Evidence: CLI transcript of brief scaffold + DOD
Evidence: Behavioral contract checks on generated briefs
self_start_axi_run: PASS no_wait_for_firstmate: PASS working_transition: PASS final_done_after_ci: PASS preserves_ask_user: PASS no_yes_flag: PASS intent_contract_present: PASS obsolete_handoff_absent: PASS premature_done_summary_absent: PASS complete_only_when_committed_absent: PASS direct_pr_unchanged_no_self_start: PASS local_only_unchanged_no_self_start: PASS direct_pr_still_opens_pr: PASS local_only_still_local: PASS ALL: PASSEvidence: fm-brief.test.sh output
Pipeline
Updates from git push no-mistakes
✅ **intent** - passed
✅ No issues found.
✅ **Rebase** - passed
✅ No issues found.
✅ **Review** - passed
✅ No issues found.
✅ **Test** - passed
✅ No issues found.
bash tests/fm-brief.test.sh(includestest_no_mistakes_dod_wordingandtest_ship_mode_is_explicit_not_registryself-start assertions)FM_HOME=... ./bin/fm-brief.sh demo-self-start sample-repo --mode no-mistakesand inspected generatedbrief.mdDefinition of doneFM_HOME=... ./bin/fm-brief.sh demo-direct sample-repo --mode direct-PRand... demo-local ... --mode local-onlyconsistency checksBefore/after DOD comparison against base345de4evs target0ca94fbVerifiedAGENTS.mdunchanged and already aligned with same-worker no-mistakes start✅ **Document** - passed
✅ No issues found.
✅ **Lint** - passed
✅ No issues found.
✅ **Push** - passed
✅ No issues found.