Repository navigation
Preview controller migration before restoring private state - #69
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Controller restore previously published private state immediately after validation. Add --plan to run the same snapshot, mapping, TLS, staged Settings/database and final source checks, then return before publication. Temporary private staging is cleaned; the report exposes counts, mapped roots and disabled IDs, without credentials or handoff contents. Default restore behavior remains compatible, and applying after a preview revalidates destination conflicts.
Validation (2026-11-15): 23 focused restore cases and all 432 regression tests pass locally. Tests compare source/target bytes and permissions, exercise both validation paths, confirm cleanup on a late source-check failure, verify CLI default/flag behavior, and reject a conflict introduced after preview. Documentation starts migration with preview and corrects outdated HTTPS/client and Foundry evidence wording. No live Foundry operations were performed.
Agent review: rejected task 7a3d07f5cbaf4d229adff1f65a0cb887 for unrelated dependency/version changes; c67edcdbe8b847ca82bc75366c5833fb failed with tool_denied; rejected cef1a2fbb99e45d6bbc6c11658c5c65b for placing logic after restore and omitting the actual signature/call changes. Forge supplied the corrected minimal implementation and independent tests. No rejected proposal was applied.
Increment of #64, which remains open for general project-history migration, consolidated identity/service setup and operational acceptance. Preview validates controller restoration only; selected source reads and running-service acceptance remain separate.