Repository navigation
Reject duplicate JSON keys in native worker results - #113
Merged
Merged
Conversation
This was referenced Nov 18, 2026
kudama
marked this pull request as ready for review
November 18, 2026 19:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Native work orders currently accept repeated JSON keys because ordinary parsing silently keeps the last value. A worker result can therefore pass source/schema validation after part of its raw output has been discarded.
Reuse the existing strict JSON parser for native result admission and execution-result correspondence, while retaining bounded file loading. Duplicate keys at any nesting depth and nonstandard constants are rejected; source, tool and review boundaries are unchanged.
Validation:95 work-order, native handoff and receipt-recovery checks pass in an isolated controller copy. Restoring both legacy worker parsing calls makes both new native duplicate-key cases fail, confirming they reproduce the original defect. No deployed controller or model routing changed.
Fixes #112. Found during the Qwen3.8 handoff evaluation in #111; draft for review.