docs, net, service-objects: Add a section for Service lifecycle#969
docs, net, service-objects: Add a section for Service lifecycle#969EdDev wants to merge 1 commit intokubevirt:mainfrom
Conversation
orelmisan
left a comment
There was a problem hiding this comment.
Thank you for the PR @EdDev!
Unfortunately, kubevirt/kubevirt#16884 didn't make it to the cut of release-1.8, so the feature will only be available in v1.9 (unless we backport of course).
|
/hold |
5325223 to
8cddf6f
Compare
Thank you. Done. |
|
/assign @orelmisan @frenzyfriday |
| While creating the service explicitly, it is up to the user to explicitly | ||
| cleanup the service. | ||
| From v1.9 the implicit service creation through `virtctl expose` adds an | ||
| `ownerRefernce` to the service object, binding the service to the VM/VMI. |
There was a problem hiding this comment.
Typo:
| `ownerRefernce` to the service object, binding the service to the VM/VMI. | |
| `ownerReference` to the service object, binding the service to the VM/VMI. |
nit: Consider adding a link to https://kubernetes.io/docs/concepts/overview/working-with-objects/owners-dependents/.
|
|
||
| ## Service lifecycle | ||
|
|
||
| Service objects may be created explicitly by an user or implicitly |
There was a problem hiding this comment.
| Service objects may be created explicitly by an user or implicitly | |
| Service objects may be created explicitly by a user or implicitly |
| through the `virtctl expose` command. | ||
|
|
||
| While creating the service explicitly, it is up to the user to explicitly | ||
| cleanup the service. |
There was a problem hiding this comment.
nit:
| cleanup the service. | |
| clean up the service. |
| `ownerRefernce` to the service object, binding the service to the VM/VMI. | ||
| As a result, the service will be collected by the garbage-collector once |
There was a problem hiding this comment.
| `ownerRefernce` to the service object, binding the service to the VM/VMI. | |
| As a result, the service will be collected by the garbage-collector once | |
| As a result, the service will be collected by the k8s garbage-collector once |
8cddf6f to
759f120
Compare
|
change: Rebase |
In v1.9 `virtctl expose` adds a `ownerReference` to the Service object and binds it to the VM/VMI object. Allowing proper cleanup of Services and avoiding orphan services. Signed-off-by: Edward Haas <edwardh@redhat.com>
759f120 to
d4cf555
Compare
|
change: Answered review comments from @orelmisan . |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: orelmisan The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
In v1.9
virtctl exposeadds aownerReferenceto the Service object and binds it to the VM/VMI object.Allowing proper cleanup of Services and avoiding orphan services.
This change complements kubevirt/kubevirt#16884 by documenting it towards v1.9.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.
Release note: