Skip to content

[scanner] fix: resolve build breaks from PRs #17970 and #17971#18017

Merged
kubestellar-hive[bot] merged 1 commit into
mainfrom
scanner/fix-17980
Jun 12, 2026
Merged

[scanner] fix: resolve build breaks from PRs #17970 and #17971#18017
kubestellar-hive[bot] merged 1 commit into
mainfrom
scanner/fix-17980

Conversation

@kubestellar-hive

Copy link
Copy Markdown
Contributor

Fixes #17980
Fixes #17981

Summary

This PR resolves critical build failures introduced by PRs #17970 and #17971.

Changes

  1. Fixed import paths in GPUReservations.tsx and Layout.tsx

    • Changed ../lib/demoMode@/lib/demoMode to use the correct path alias
  2. Fixed Promise handling in useFeatureRequests.ts

    • Changed isDemoUser().then(setIsDemoMode)isDemoUser().then((isDemo) => setIsDemoMode(isDemo))
    • This prevents TypeScript from treating the Promise as the state value

Build Errors Resolved

  • Cannot find module '../lib/demoMode' in GPUReservations.tsx and Layout.tsx
  • Type 'Promise<boolean>' is not assignable to type 'boolean' in FeatureRequestModal.tsx
  • ❌ Multiple This condition will always return true since this 'Promise<boolean>' is always defined errors in useFeatureRequests.ts

Testing

CI will validate the build and lint passes.

Signed-off-by: Scanner Bot <scanner@kubestellar.io>
Copilot AI review requested due to automatic review settings June 12, 2026 10:08

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Jun 12, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign clubanderson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions

Copy link
Copy Markdown
Contributor

👋 Hey @kubestellar-hive[bot] — thanks for opening this PR!

🤖 This project is developed exclusively using AI coding assistants.

Please do not attempt to code anything for this project manually.
All contributions should be authored using an AI coding tool such as:

This ensures consistency in code style, architecture patterns, test coverage,
and commit quality across the entire codebase.


This is an automated message.

@netlify

netlify Bot commented Jun 12, 2026

Copy link
Copy Markdown

Deploy Preview for kubestellarconsole ready!

Name Link
🔨 Latest commit d989696
🔍 Latest deploy log https://app.netlify.com/projects/kubestellarconsole/deploys/6a2bdaafb2feaf000822e108
😎 Deploy Preview https://deploy-preview-18017.console-deploy-preview.kubestellar.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions Bot added the ai-generated Pull request generated by AI label Jun 12, 2026
@kubestellar-prow kubestellar-prow Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 12, 2026
@github-actions

Copy link
Copy Markdown
Contributor

✅ Test Coverage Check

All new source files in this PR have corresponding test files.

Checked web/src/hooks/ and web/src/components/ against origin/main.

@kubestellar-hive kubestellar-hive Bot merged commit d8e4ce9 into main Jun 12, 2026
38 of 49 checks passed
@kubestellar-prow kubestellar-prow Bot deleted the scanner/fix-17980 branch June 12, 2026 10:34
@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

Check out what's new:

Stay connected: Slack #kubestellar-dev | Multi-Cluster Survey

@github-actions

Copy link
Copy Markdown
Contributor

❌ Post-Merge Verification: failed

Commit: d8e4ce9ef3a5c9cf48e001ec0b8497c325c0cdb6
Specs run: GPUOverview.spec.ts navbar-responsive.spec.ts smoke.spec.ts
Report: https://github.com/kubestellar/console/actions/runs/27410336226

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-generated Pull request generated by AI dco-signoff: yes Indicates the PR's author has signed the DCO. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. tier/2-standard

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 Build broken after merging PR #17971 🐛 Build broken after merging PR #17970

1 participant