[scanner] fix: resolve build breaks from PRs #17970 and #17971#18017
Conversation
Signed-off-by: Scanner Bot <scanner@kubestellar.io>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
👋 Hey @kubestellar-hive[bot] — thanks for opening this PR!
This is an automated message. |
✅ Deploy Preview for kubestellarconsole ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Test Coverage CheckAll new source files in this PR have corresponding test files. Checked |
|
Thank you for your contribution! Your PR has been merged. Check out what's new:
Stay connected: Slack #kubestellar-dev | Multi-Cluster Survey |
❌ Post-Merge Verification: failedCommit: |
Fixes #17980
Fixes #17981
Summary
This PR resolves critical build failures introduced by PRs #17970 and #17971.
Changes
Fixed import paths in
GPUReservations.tsxandLayout.tsx../lib/demoMode→@/lib/demoModeto use the correct path aliasFixed Promise handling in
useFeatureRequests.tsisDemoUser().then(setIsDemoMode)→isDemoUser().then((isDemo) => setIsDemoMode(isDemo))Build Errors Resolved
Cannot find module '../lib/demoMode'in GPUReservations.tsx and Layout.tsxType 'Promise<boolean>' is not assignable to type 'boolean'in FeatureRequestModal.tsxThis condition will always return true since this 'Promise<boolean>' is always definederrors in useFeatureRequests.tsTesting
CI will validate the build and lint passes.