Skip to content

[scanner] fix: navigation and React efficiency improvements#18014

Merged
kubestellar-hive[bot] merged 1 commit into
mainfrom
scanner/fix-18003
Jun 12, 2026
Merged

[scanner] fix: navigation and React efficiency improvements#18014
kubestellar-hive[bot] merged 1 commit into
mainfrom
scanner/fix-18003

Conversation

@kubestellar-hive

Copy link
Copy Markdown
Contributor

Fixes #18003
Fixes #18004

Summary

This PR addresses Auto-QA findings for navigation/routing and React efficiency by replacing wildcard imports with named imports in test files.

Changes

  • useClusterStats.test.ts: Use named import for useClusterStats
  • useClusterFiltering.test.ts: Use named import for useClusterFiltering
  • APIKeySettings.test.tsx: Use named imports for APIKeySettings and buildBaseURLPayload
  • AgentStatus.test.tsx: Use named imports for AgentStatus and AgentInstallBanner
  • AgentSetupDialog.test.tsx: Use named import for AgentSetupDialog

Benefits

  • Improved tree-shaking potential
  • Better code clarity and explicit dependencies
  • Follows React best practices for imports

Notes

  • The mission control test file was intentionally left unchanged as it uses wildcard imports legitimately for vi.spyOn() mocking
  • The sections-exports test was intentionally left unchanged as it validates barrel exports
  • The LayoutBanners test already has correct external link handling (target/rel attributes)

- Replace wildcard imports with named imports in test files
- Improves tree-shaking and code clarity
- Affects: useClusterStats, useClusterFiltering, APIKeySettings, AgentStatus, AgentSetupDialog tests

Fixes #18003
Fixes #18004

Signed-off-by: Scanner Bot <scanner@kubestellar.io>
Copilot AI review requested due to automatic review settings June 12, 2026 10:06
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Jun 12, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign clubanderson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@netlify

netlify Bot commented Jun 12, 2026

Copy link
Copy Markdown

Deploy Preview for kubestellarconsole ready!

Name Link
🔨 Latest commit 6f2b55b
🔍 Latest deploy log https://app.netlify.com/projects/kubestellarconsole/deploys/6a2bda1eb658250008c5d8cf
😎 Deploy Preview https://deploy-preview-18014.console-deploy-preview.kubestellar.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions Bot added the ai-generated Pull request generated by AI label Jun 12, 2026
@kubestellar-prow kubestellar-prow Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 12, 2026
@github-actions

Copy link
Copy Markdown
Contributor

👋 Hey @kubestellar-hive[bot] — thanks for opening this PR!

🤖 This project is developed exclusively using AI coding assistants.

Please do not attempt to code anything for this project manually.
All contributions should be authored using an AI coding tool such as:

This ensures consistency in code style, architecture patterns, test coverage,
and commit quality across the entire codebase.


This is an automated message.

@github-actions

Copy link
Copy Markdown
Contributor

✅ Test Coverage Check

All new source files in this PR have corresponding test files.

Checked web/src/hooks/ and web/src/components/ against origin/main.

@kubestellar-hive kubestellar-hive Bot merged commit 655f773 into main Jun 12, 2026
38 of 49 checks passed
@kubestellar-prow kubestellar-prow Bot deleted the scanner/fix-18003 branch June 12, 2026 10:33
@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

Check out what's new:

Stay connected: Slack #kubestellar-dev | Multi-Cluster Survey

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-generated Pull request generated by AI dco-signoff: yes Indicates the PR's author has signed the DCO. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tier/1-lightweight

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Auto-QA] React efficiency improvements available [Auto-QA] Navigation and routing improvements needed

1 participant