feat(): add Conditions to ClusterStatus for worker-to-hub connection health - #47
Open
sumanthd032 wants to merge 2 commits into
Open
feat(): add Conditions to ClusterStatus for worker-to-hub connection health#47sumanthd032 wants to merge 2 commits into
sumanthd032 wants to merge 2 commits into
Conversation
…ller HA Adds the API carrier for Active/Standby high availability of the KubeSlice controller, where two hub clusters run the controller and worker clusters must find the Active again after a failover with no manual reconfiguration. - ClusterStatus.ActiveController (*ActiveControllerInfo) - ActiveControllerInfo: Endpoint, CABundle, ActiveIdentity, LastUpdated Each hub writes this field about itself, on its own API server, and only while it holds leadership. A Standby's copy is populated by the state mirror from the Active, so it names the Active rather than itself. That lets a worker watching both hub endpoints identify the Active by the rule "trust whichever endpoint is reachable and reports an ActiveIdentity matching that endpoint's own identity", without needing to know which role either hub currently holds, and without inferring a death from a timeout. LastUpdated gives a consumer a deterministic tie-break if a partition causes both hubs to self-declare at once; without a freshness signal on the object itself a worker would have to read coordination.k8s.io Leases across clusters to resolve it. StorageCapabilities.LastUpdated in this same struct is existing precedent for the pattern. Additive only, all fields omitempty, no existing field changed. A deployment that never publishes the field leaves it nil, which is exactly the non-HA case. Fixes kubeslice#45 Signed-off-by: Sumanth D <sumanthd032@gmail.com>
…alth Worker operator will use this to report ControllerConnected and ControllerEndpointSynced. Signed-off-by: Sumanth D <sumanthd032@gmail.com>
7 tasks
sumanthd032
added a commit
to sumanthd032/worker-operator
that referenced
this pull request
Aug 26, 2026
Pulls in ActiveController/StorageCapabilities (already merged locally, never vendored) and the new Conditions field kubeslice#469 needs. Pinned to the fork commit behind kubeslice/apis#47; drop the replace once that merges and a release carries the field. Signed-off-by: Sumanth D <sumanthd032@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
Conditions []metav1.ConditiontoClusterStatus, so a worker operator can report aControllerConnected/ControllerEndpointSynced-style condition about its own hub connection. Types and deepcopy only, no CRD regeneration, matching the precedent set by the existingActiveControllerfield.Stacked on #46. Only this one field is new here.
How Has This Been Tested?
go build ./...andgo vet ./...clean. Deepcopy verified by inspection: additive only,zz_generated.deepcopy.godiff is exactly the new slice's copy loop.Checklist:
Does this PR introduce a breaking change for other components like worker-operator?
No. Purely additive field.