Generate Python client-go retry wiring - #304
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sttts The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>
b48aab0 to
359a4ca
Compare
Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>
Signed-off-by: Dr. Stefan Schimanski <stefan.schimanski@gmail.com>
|
thanks for the PR. #305 (comment) upgrades the openapi generator to v7.24.0, the patches in this PR would need to be reworked after the upgrade. Let's wait a few days for that. |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@sttts could you please rebase? thanks. |
|
Also, don't we want this to be updated in the upstream code generator? Instead of patching here? Also, if we do need patches, I would suggest that we carry the patches in the python client repository, not the gen repository, that's what we do for Java: https://github.com/kubernetes-client/java/blob/master/.github/workflows/generate.yml#L127 |
|
+1 to what @brendandburns said, better to update the upstream openapi generator. |
Summary
client_go_retriesandclient_go_retry_backoffconfiguration fields to generated clientskubernetes.utils.retryfor sync andkubernetes.aio.utils.retryfor AIOValidation
python-legacytemplatesgit diff --checkDepends on kubernetes-client/python#2634.