ci: add shell script linting workflow#3708
Conversation
Signed-off-by: Aniket Patil <aniketpatil2027@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
🎉 Welcome to the Kubeflow Trainer! 🎉 Thanks for opening your first PR! We're happy to have you as part of our community 🚀 Here's what happens next:
Join the community:
Feel free to ask questions in the comments if you need any help or clarification! |
There was a problem hiding this comment.
Pull request overview
This PR adds repo-wide shell script formatting (shfmt) and linting (ShellCheck) enforcement via Make targets, pre-commit hooks, and a dedicated GitHub Actions workflow, aligning this repository with Kubeflow’s CI standards (per #3703).
Changes:
- Add
make shell-fmt(shfmt) andmake shell-lint(shellcheck) targets plus tool version pinning in the Makefile. - Add local pre-commit hooks to run the new shell formatting and lint targets.
- Add a new
Shell LintGitHub Actions workflow to enforce shell formatting and linting on PRs and pushes.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Makefile | Adds shfmt/shellcheck version pins, Make targets, and a ShellCheck download helper. |
| .pre-commit-config.yaml | Adds local pre-commit hooks to run make shell-fmt and make shell-lint. |
| .github/workflows/shell-lint.yaml | Adds CI workflow to enforce shell formatting and run ShellCheck. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Aniket Patil <aniketpatil2027@gmail.com>
Signed-off-by: Aniket Patil <aniketpatil2027@gmail.com>
fixes #3703