Skip to content
This repository was archived by the owner on Sep 19, 2022. It is now read-only.

Updated the image name format for the gcr.io.#300

Open
wuchen03 wants to merge 1 commit into
kubeflow:masterfrom
wuchen03:master
Open

Updated the image name format for the gcr.io.#300
wuchen03 wants to merge 1 commit into
kubeflow:masterfrom
wuchen03:master

Conversation

@wuchen03

Copy link
Copy Markdown

While trying these examples, I found that the format of the image address is not correct, updated them.

@google-cla

google-cla Bot commented Sep 10, 2020

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@k8s-ci-robot

Copy link
Copy Markdown

Hi @wuchen03. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gaocegege gaocegege left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

/assign @andreyvelich @johnugeorge

@gaocegege

Copy link
Copy Markdown
Member

Thanks for your contribution! 🎉 👍

Please sign Google's CLA, thanks.

@wuchen03

Copy link
Copy Markdown
Author

@googlebot I signed it!

@andreyvelich andreyvelich left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/ok-to-test

@andreyvelich

Copy link
Copy Markdown
Member

Thanks @wuchen03, I think we should wait until we merge #293 to fix Travis.

@k8s-ci-robot

Copy link
Copy Markdown

@wuchen03: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
kubeflow-pytorch-operator-presubmit eaabf13 link /test kubeflow-pytorch-operator-presubmit

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Jeffwan

Jeffwan commented Oct 22, 2020

Copy link
Copy Markdown
Member

@wuchen03

Can you rebase the master changes to pass tests? I can approve the change later

@k8s-ci-robot

Copy link
Copy Markdown

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot removed the lgtm label Oct 27, 2020
@k8s-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: wuchen03
To complete the pull request process, please assign andreyvelich after the PR has been reviewed.
You can assign the PR to them by writing /assign @andreyvelich in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.1%) to 64.11% when pulling 8e9253c on wuchen03:master into 92fd22d on kubeflow:master.

@aws-kf-ci-bot

Copy link
Copy Markdown

@wuchen03: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
kubeflow-pytorch-operator-presubmit-e2e 8e9253c link /test kubeflow-pytorch-operator-presubmit-e2e
kubeflow-pytorch-operator-presubmit 8e9253c link /test kubeflow-pytorch-operator-presubmit

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants