Skip to content

fix: correct broken README example paths and kustomize command#822

Merged
google-oss-prow[bot] merged 1 commit into
kubeflow:masterfrom
immanuwell:fix/readme-broken-example-paths
Jul 3, 2026
Merged

fix: correct broken README example paths and kustomize command#822
google-oss-prow[bot] merged 1 commit into
kubeflow:masterfrom
immanuwell:fix/readme-broken-example-paths

Conversation

@immanuwell

Copy link
Copy Markdown
Contributor

This fixes a couple README commands that break on a fresh clone. Small papercut, but pretty user-facing.

Bug
cat examples/pi/pi-intel.yaml
cat examples/pi/pi-mpich.yaml
both fail with No such file or directory

kubectl kustomize base | kubectl apply -f -
also points to a base/ dir that is not in this repo.

Fix
Use examples/v2beta1/pi/... and manifests/overlays/kubeflow instead.

Repro
Run those commands from repo root.

Related #596

@google-oss-prow google-oss-prow Bot requested review from carmark and gaocegege July 1, 2026 11:32
Signed-off-by: immanuwell <pchpr.00@list.ru>
@immanuwell immanuwell force-pushed the fix/readme-broken-example-paths branch from 7b53890 to 0dfd856 Compare July 1, 2026 12:37

@tenzen-y tenzen-y left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
/lgtm
/approve

@google-oss-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow Bot merged commit fce9df5 into kubeflow:master Jul 3, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants