Skip to content

Update org.yaml#366

Closed
danielsiwiec wants to merge 1 commit into
kubeflow:masterfrom
danielsiwiec:patch-1
Closed

Update org.yaml#366
danielsiwiec wants to merge 1 commit into
kubeflow:masterfrom
danielsiwiec:patch-1

Conversation

@danielsiwiec

Copy link
Copy Markdown

No description provided.

@k8s-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: danielsiwiec
To complete the pull request process, please assign james-jwu after the PR has been reviewed.
You can assign the PR to them by writing /assign @james-jwu in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeflow-bot

Copy link
Copy Markdown

This change is Reviewable

@k8s-ci-robot

Copy link
Copy Markdown

Hi @danielsiwiec. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@terrytangyuan terrytangyuan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you share a list of your contributions?

@danielsiwiec

Copy link
Copy Markdown
Author

@terrytangyuan I just made this PR to resolve a typo in one of the sample notebooks kubeflow/metadata#242

@terrytangyuan

Copy link
Copy Markdown
Member

Thanks. It would be great to see more contributions before we add you as a member. Feel free to ping here when you are ready. Looking forward to seeing your contributions!

@danielsiwiec

Copy link
Copy Markdown
Author

@terrytangyuan ah, I see. I was just following the contributor's guide here. would be helpful to make it clear, that it's not needed for every PR. thanks!

@stale

stale Bot commented Jan 24, 2021

Copy link
Copy Markdown

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale Bot closed this Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants