Clarify excess config behavior preserves running aggregator#329
Merged
fekete-robert merged 1 commit intoMay 12, 2026
Merged
Conversation
When multiple FluentdConfig or SyslogNGConfig resources exist in the same namespace, the documentation now clearly states that: - The previously-associated config continues to operate normally - Log forwarding remains uninterrupted while resolving the conflict - Users should delete the excess config to resolve the issue Also standardized SyslogNGConfig capitalization. Related: kube-logging/logging-operator#2232
| ``` | ||
|
|
||
| If there is a conflict, the controller adds a problem to both resources so that both the operations team and the tenant users can notice the problem. For example, if a `FluentdConfig` is already registered to a `Logging` resource and you create another `FluentdConfig` resource in the same namespace, then the first `FluentdConfig` is left intact, while the second one should have the following status: | ||
| If there is a conflict, the controller adds a problem to both resources so that both the operations team and the tenant users can notice the problem. The previously-associated `FluentdConfig` continues to operate normally, and log forwarding remains uninterrupted while you resolve the excess configuration. |
Contributor
Author
There was a problem hiding this comment.
Added clarification that the aggregator keeps running based on PR #2232 which fixes the bug where creating a second FluentdConfig would tear down the running aggregator. The fix in repository.go preserves the previously-associated configuration recorded in Logging.Status.FluentdConfigName.
| ``` | ||
|
|
||
| If there is a conflict, the controller adds a problem to both resources so that both the operations team and the tenant users can notice the problem. For example, if a `syslogNGConfig` is already registered to a `Logging` resource and you create another `syslogNGConfig` resource in the same namespace, then the first `syslogNGConfig` is left intact, while the second one should have the following status: | ||
| If there is a conflict, the controller adds a problem to both resources so that both the operations team and the tenant users can notice the problem. The previously-associated `SyslogNGConfig` continues to operate normally, and log forwarding remains uninterrupted while you resolve the excess configuration. |
Contributor
Author
There was a problem hiding this comment.
Added clarification that the aggregator keeps running based on PR #2232 which fixes the bug where creating a second SyslogNGConfig would tear down the running aggregator. The fix in repository.go preserves the previously-associated configuration recorded in Logging.Status.SyslogNGConfigName.
fekete-robert
approved these changes
May 12, 2026
Contributor
Author
|
Just a reminder: I review PR comments by default. If you want me to ignore a specific comment, start it with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Open this suggestion in Promptless to view citations and reasoning process
Documents that when multiple FluentdConfig or SyslogNGConfig resources exist in the same namespace, the previously-associated config continues operating normally and log forwarding remains uninterrupted. Adds resolution guidance to delete excess configs.
Trigger Events
Tip: Use Vale? Add your vale.ini when setting up your Docs Collection.