Repository navigation
fix(T13890): no warning when session end finds no session (exit 24/31) - #2367
Merged
Merged
Conversation
runBounded takes benign exit codes; the Stop dispatcher's session end passes SESSION_END_BENIGN_EXITS (ExitCode.SESSION_UNBOUND, ExitCode.SESSION_NOT_FOUND), so a Stop with no bound session prints nothing. Other non-zero exits still warn once. Follow-up to #2363 (review-hotfix LOW). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #2363, for review-hotfix's LOW finding there.
When a Stop has no bound session,
cleo session endexits withE_SESSION_UNBOUND(24) orE_SESSION_NOT_FOUND(31). The Stop dispatcher was printing "session end failed … (exit 24)" for that expected case.runBounded(..., benignExits = []): a non-zero exit listed inbenignExitsprints no warning. Every other non-zero exit, a signal, a spawn error and an overrun still print one line.SESSION_END_BENIGN_EXITSis[ExitCode.SESSION_UNBOUND, ExitCode.SESSION_NOT_FOUND], using the named constants from@cleocode/contracts/exit-codes.js. The dispatcher's session end passes it.Verification
CI only, per the no-local-heavy-runs directive.
--base origin/main) pass.🤖 Generated with Claude Code