Repository navigation
refactor(sync): cloud sync classifies skipped legs by a typed refusal kind (T13315) - #1970
Open
kryptobaseddev wants to merge 2 commits into
Open
kryptobaseddev wants to merge 2 commits into
kryptobaseddev wants to merge 2 commits into
Conversation
… kind (T13315) #1962 review nit: SKIP_REASONS matched refusal message text, so a reworded refusal would silently turn a skip into a refusal. Push and pull reports now carry refusedKind; classifySyncLegs decides skipped, refused, disabled and whether the pull position is meaningful from the kinds alone. Tests: reworded messages still skip; a skip-looking message with a non-skip kind is a refusal. Two mutations killed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task: T13315
Stacked on #1968 (feat/T13256-idle-no-pingpong). This is review-hotfix's non-blocking nit on #1962.
Change
PushStreamReport.refusedKindis one ofschema-missing,push-off,no-genesis,genesis-pendingorstore-behind. Every refusal site sets it.PullStreamReport.refusedKindispull-offorsegment.classifySyncLegs(push, pull)is exported with TSDoc and sits incloud/nexus-vault.ts. It works out skipped, refused, disabled and pull-skipped from the kinds alone.SKIP_REASONS, the list of message regexes, is removed.syncOneStreamuses the classifier, and its behaviour is otherwise unchanged:disabledmeans both flags are off;Verification
no-genesisandgenesis-pendingcount as skipped;store-behindandsegmentcount as refused;no-genesisfrom the skips fails a test, and so does classifying the pull by its message.nexus-vault,pushandpullpass, 126/126.nexus-vault-clipasses, 37/37.tscis clean, and biome is clean.--base), 40, 4 and 32 (--base) pass;lint-changesetspasses.🤖 Generated with Claude Code