Repository navigation
fix(T13261): row-identity ref probe runs no JS hash per dangling ref - #1966
Open
kryptobaseddev wants to merge 1 commit into
Open
kryptobaseddev wants to merge 1 commit into
kryptobaseddev wants to merge 1 commit into
Conversation
… ref (T13261) The pending probe evaluated the AC text hash (a JS function) on every NULL ac_text_hash row on every fill-on open. It now asks the same question in SQL: the hash is non-NULL iff the criterion's text is a string (typeof = 'text'). The fill pass is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the review-hotfix LOW on #1888 (C1). On every fill-on open,
rowIdentityFillPending'sref:probe evaluatedstoredRefSql, which forac_text_hashcalls the JS AC-text hash, on every NULL stored-ref row. A store with many legitimately dangling bindings paid one JS call per row on every open.The probe now uses
storedRefPresentSql, which is true exactly whenstoredRefSqlwould be non-NULL, in plain SQL:text_hash:acTextHashreturns non-NULL iff the criterion's text is a JS string, so the probe checks(SELECT typeof(text) …) = 'text'.refUidSql … IS NOT NULL, the same pure-SQL condition as before.The fill pass still derives the values with
storedRefSql.Tests
row-identity-steady-open.test.tsadds a test for 40 bindings whose criterion is gone:ref:entries are reported;Mutation check: with the old probe restored, the test fails on 40 hash calls.
Results: the row-identity suite passes 122/122 and
tsc -b packages/coreis clean. Gate 38 (--base origin/main) and gate 32 (PR mode) pass.Task: T13261
🤖 Generated with Claude Code