Skip to content

Rename proposal to use PR number#109

Merged
SamBarker merged 1 commit into
kroxylicious:mainfrom
SamBarker:fix-metrics-crd-number
May 10, 2026
Merged

Rename proposal to use PR number#109
SamBarker merged 1 commit into
kroxylicious:mainfrom
SamBarker:fix-metrics-crd-number

Conversation

@SamBarker
Copy link
Copy Markdown
Member

@SamBarker SamBarker commented May 10, 2026


⚠️ Proposal Numbering

This PR contains proposal files that don't follow the expected format:

Issues found:

  • proposals/099-micrometer-configuration-in-kafkaproxy-crd.md

Fix for proposals/099-micrometer-configuration-in-kafkaproxy-crd.md:

git mv proposals/099-micrometer-configuration-in-kafkaproxy-crd.md proposals/109-micrometer-configuration-in-kafkaproxy-crd.md
# Update title: remove any old number prefix and add PR number
sed -i.bak '0,/^# /{s/^# \([0-9]\{3\}\|xxx\|nnn\|000\) - /# 109 - /; t; s/^# /# 109 - /}' proposals/109-micrometer-configuration-in-kafkaproxy-crd.md && rm proposals/109-micrometer-configuration-in-kafkaproxy-crd.md.bak
git add proposals/109-micrometer-configuration-in-kafkaproxy-crd.md
git commit -m "Rename proposal to use PR number 109"
git push

Note: The commands above can be copied and pasted directly into your terminal. The sed command will automatically preserve your title text.

See proposals/README.md for the complete workflow.

Signed-off-by: Sam Barker <sam@quadrocket.co.uk>
@SamBarker SamBarker requested a review from a team as a code owner May 10, 2026 21:16
@SamBarker SamBarker merged commit a47ec72 into kroxylicious:main May 10, 2026
2 checks passed
@SamBarker SamBarker deleted the fix-metrics-crd-number branch May 10, 2026 21:20
@robobario
Copy link
Copy Markdown
Member

that was a little interesting that the naming failure in this PR passed it's check. In this case it might be preferable to have the check fail and have to do an override merge since we're doing an odd operation.

@SamBarker
Copy link
Copy Markdown
Member Author

that was a little interesting that the naming failure in this PR passed it's check. In this case it might be preferable to have the check fail and have to do an override merge since we're doing an odd operation.

The PR it was fixing merged normally as well. I hadn't realised it was supposed to gate PRs as opposed to just being a warning

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants