Rename proposal to use PR number#109
Merged
Merged
Conversation
Signed-off-by: Sam Barker <sam@quadrocket.co.uk>
robobario
approved these changes
May 10, 2026
Member
|
that was a little interesting that the naming failure in this PR passed it's check. In this case it might be preferable to have the check fail and have to do an override merge since we're doing an odd operation. |
Member
Author
The PR it was fixing merged normally as well. I hadn't realised it was supposed to gate PRs as opposed to just being a warning |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains proposal files that don't follow the expected format:
Issues found:
proposals/099-micrometer-configuration-in-kafkaproxy-crd.mdFix for
proposals/099-micrometer-configuration-in-kafkaproxy-crd.md:Note: The commands above can be copied and pasted directly into your terminal. The sed command will automatically preserve your title text.
See proposals/README.md for the complete workflow.