[codex] Fix server package import regression#11
Draft
kristoffersodersten wants to merge 2 commits into
Draft
Conversation
- Added __init__.py files to all server subdirectories (intent, model, operations, runtime, task) to enable proper Python package imports - Fixed import statements in server modules (ollama_client, nano_server, runtime_profiles) to use absolute imports - Updated eslint.config.js to support .mjs files with Node.js globals for scripts - All TypeScript builds successfully, ESLint passes (0 errors), and all tests pass (28/28) - Python modules now import correctly without ModuleNotFoundError Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
server.ollama_clientto resolve runtime profile helpers through theserverpackage pathWhy
Recent import/package work added
serverpackage markers, butOllamaClientstill performed a top-levelruntime_profilesimport inside its default config path. That failure was swallowed, so package imports silently fell back to generic defaults instead of the selected runtime profile.Impact
Validation
python3 -m unittest discover -s tests/server -p 'test_package_imports.py'pnpm lintpnpm test