Address issues #19, #24, #25, #29, #30#33
Open
it-publisher wants to merge 7 commits into
Open
Conversation
krios2146#29, krios2146#30 - fix(krios2146#30): headers underline now applies in both Reading view and Live Preview (.HyperMD-header-1/-2); replaced invalid body.h1-underline.markdown-rendered selector - fix(krios2146#29): disabled buttons no longer show cursor:pointer on hover; added explicit cursor:not-allowed - feat(krios2146#24): style <kbd> tag in GitHub style (mono font, border, inset shadow) - fix(krios2146#25): table font size now follows --font-text-size, fixes inconsistent sizing in pop-out windows - feat(krios2146#19): add GitHub Dark Dimmed variant as a class-toggle in Style Settings (applies on .theme-dark) - chore: bump version to 1.2.0 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
- Add kbd tag and Dark Dimmed to Features - Add Headers underline and Dark Dimmed toggle to Theme Settings Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Adopt the broader theme rework (palette refresh, data-task checkbox icons, Vimrc plugin styling) while preserving the issue fixes from 1.2.0. Reapplied on top: - fix(krios2146#30): headers underline selectors (.HyperMD-header-1/-2) - fix(krios2146#29): button:not(:disabled):hover + cursor:not-allowed - fix(krios2146#25): font-size: var(--font-text-size) on tables - feat(krios2146#24): kbd tag in GitHub style - feat(krios2146#19): Dark Dimmed class-toggle and palette Quality fixes on incoming code: - --bold-color: moved from body (hardcoded #7ee787) into .theme-dark as var(--color-green); avoids ugly green bold on light theme and keeps bold in sync when palette changes - --callout-quote: var(--color-cyan-rgb) instead of hardcoded RGB Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Pull a few accents from brand.github.com/foundations/color to bring the theme closer to current GitHub brand identity: - .theme-dark btn-primary: #08872B → #0FBF3E (Green 5 → Green 4 hover) - .theme-dark --color-purple: #d2a8ff → #B870FF (Purple 2) - .theme-light --color-purple: #876be0 → #8534F3 (Copilot Purple) - .theme-dark --color-orange: #c9510c → #F08A3A (Orange 2) - .theme-light --color-orange: #d96c00 → #C53211 (Orange 4) - --text-highlight-bg: 255,208,0 → 216,189,14 (Lime 3) in all schemes Colorblind variants and Dark Dimmed keep their own palettes. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Two Style Settings class-toggles that spot-highlight notes by topic, following GitHub brand guidance to use vibrant colors sparingly. - copilot-accent: callouts [!ai|copilot|gpt|llm|prompt] and matching tags get Copilot Purple (#8534F3) - security-accent: callouts [!security|secret|encrypted|private|vault] and matching tags get Security Blue (#3094FF) Tag highlighting works in Reading view; Live Preview doesn't expose tag names via CSS selectors so it falls back to default styling there. Bump to 1.3.0. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Apply font-feature-settings: "calt", "liga", "ss01" to code, pre, .cm-editor, .cm-line, .HyperMD-codeblock and rendered code blocks. Enables ligatures in fonts that support them (Monaspace, JetBrains Mono, Fira Code, Cascadia Code) without affecting fonts that don't. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bundle of fixes and enhancements addressing 5 open issues.
body.h1-underline.markdown-rendered h1was invalid (.markdown-renderedis never onbody); replaced withbody.h1-underline h1+body.h1-underline .HyperMD-header-1(same for H2).cursoraspointer#29 — Disabled buttons no longer showcursor: pointer. Changedbutton:hovertobutton:not(:disabled):hoverand added explicitcursor: not-allowedfor:disabled.<kbd>tag styled in GitHub style: mono font, border, inset shadow, themed via existing CSS vars.font-size: var(--font-text-size)ontableandinheritontd/thso the size is preserved when the table renders in a detached window..theme-darkonly; palette based on Primer'sdark_dimmed.manifest.jsonto1.2.0(matches the milestone on Add Dark dimmed #19).Test plan
not-allowed, enabled buttons still show pointer<kbd>renders with border + inset shadow in Reading view.theme-light🤖 Generated with Claude Code