Open
Conversation
1d83c16 to
ce544ad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related to issue #97
This PR adds Netherlands support to RivRetrieve via a new
NetherlandsFetcherbacked by Rijkswaterstaat WaterWebservices.What was added
rivretrieve/netherlands.pyrivretrieve/__init__.pydocs/fetchers/netherlands.rstdocs/api.rstrivretrieve/cached_site_data/netherlands_sites.csvexamples/test_netherlands_fetcher.pySupported variables
discharge_daily_meandischarge_instantaneousstage_daily_meanstage_instantaneouswater-temperature_daily_meanwater-temperature_instantaneousImplementation notes
ddapi20endpoint family and falls back to the legacy service if neededm3/dtom3/swhen needed