Open
Conversation
fe31f9d to
c228863
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related to issue #95
Implemented:
IrelandOPWFetcherrivretrieve/__init__.pyData source
Source:
Endpoints used:
https://waterlevel.ie/hydro-data/data/internet/stations/stations.jsonhttps://waterlevel.ie/hydro-data/data/internet/stations/0/{station_id}/{parameter}/year.jsonSupported variables
The new fetcher supports RivRetrieve-native daily mean variables only:
constants.DISCHARGE_DAILY_MEANconstants.STAGE_DAILY_MEANconstants.WATER_TEMPERATURE_DAILY_MEANParameter mapping:
Q-> discharge daily meanS-> stage daily meanTWater-> water temperature daily meanWhen OPW returns min / mean / max products in the same response, the fetcher explicitly selects the daily mean series.
Implementation notes
The implementation follows the existing RivRetrieve fetcher patterns used for:
Key points:
stations.jsonrivretrieve/cached_site_data/ireland_opw_sites.csvstation_no1..41000republication-safe range from the original OPW logicFiles added / updated
Added:
rivretrieve/ireland_opw.pydocs/fetchers/ireland_opw.rstexamples/test_ireland_opw_fetcher.pyrivretrieve/cached_site_data/ireland_opw_sites.csvtests/test_ireland_opw.pytests/test_data/