Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related to issue #74
This PR updates the Estonia fetcher to better match the upstream
hydrodownloadRapproach while keeping the additional metadata we want in RivRetrieve.What changed
estoniaonto the currentmaingauge_idtests/test_data/examples/get_data()method docs with Parameters, Returns, Return type, and Raisespytestdiscovery config sopytestruns the realtests/suite instead of collectingexamples/test_*.pydemo scripts as testsImplementation notes
The main design change is in metadata handling.
Before:
Now:
This is closer to
hydrodownloadR, simpler, and less brittle, while still preserving the usefularea,overlapArea,countryArea,calculationArea, anddistancefields.Result
get_metadata()andget_cached_metadata()now agree structurallyVerification
./.venv/bin/python -m pytest./.venv/bin/python -m ruff check ../.venv/bin/python -m ruff format --check ../.venv/bin/python -m sphinx -M html docs docs/_build -j autoReference
This PR was implemented on top of the rebased
estoniabranch and pushed after validation.Latest commit:
d818a2b