Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title
Related to issue #65
Body
Summary
discharge_daily_mean,stage_daily_mean, andwater-temperature_daily_mean.Paikka_Idasgauge_id, sinceNrois not unique across variables.Data source,Supported variables,Data description and API,Terms of use, plus the method docs.Why the chunking fix is needed
SYKE truncates filtered OData time-series responses at 500 rows and does not return a usable
odata.nextLinkfor these requests. Without chunking, multi-year downloads stop early. This PR avoids that by requesting long date ranges in smaller windows and concatenating the results.Verification
./.venv/bin/python -m unittest discover -s tests -p 'test*.py'./.venv/bin/ruff check ../.venv/bin/ruff format --check ../.venv/bin/sphinx-build -M html docs docs/_build -a -ELive checks
897,2025-01-01to2026-03-27returns451rows after the chunking fix.1900,2025-01-01to2026-03-27returns450available rows.3094,2025-01-01to2026-01-01returns260available rows.