Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related to issue #103
This PR adds support for Thailand via the official public ThaiWater API.
It introduces a new
ThailandFetcher, cached station metadata, tests, example usage, and Sphinx documentation.Data sources
Official/public sources used:
What is included
rivretrieve/thailand.pyrivretrieve/__init__.pySupported variables
constants.STAGE_DAILY_MEANconstants.STAGE_INSTANTconstants.DISCHARGE_DAILY_MEANconstants.DISCHARGE_INSTANTImplementation details
waterlevel_loadwaterlevel_graphflowendpoint is not used in this first versionwaterlevel_mslis populated whilewaterlevel_mis mostly nullwaterlevel_graph.data.graph_data[].valueas stage relative to MSL based on observed live source behaviorValidation
Notes
One important upstream behavior is that very large single requests can be truncated by the ThaiWater backend. This PR works around that internally by splitting long ranges into smaller windows before combining the results.