Repository navigation
docs(reconciler): during Create the Ready condition is the runtime's - #102
Merged
Merged
Conversation
The runtime writes Ready=False/Creating on every create outcome, and conditions are replaced by type, so a Ready reason a provider sets in Create never survives, and nothing reports it. The user decided on 2026-11-13 to keep that and document it: a provider's own reason goes in the returned error or in a condition type of its own, and Create must not persist status itself. Reported by aruba-provider-kog from rest-dynamic-controller 0.64.0's no-create kinds. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NSM9VYtekkTV1h9dK4WxM4
braghettos
added a commit
that referenced
this pull request
Nov 14, 2026
…'s (#103) #102 cited a measurement on a kind with no create verb as the example. That kind is served by rest-dynamic-controller, which is built on unstructured-runtime, not on this library (its go.mod at 0.64.0), so the measurement says nothing about this reconciler. The contract itself is read from this library's source and stands; the example is removed, and the status-write flap is marked as reasoned, not measured. Corrected by aruba-provider-kog and oasgen-provider. Claude-Session: https://claude.ai/code/session_01NSM9VYtekkTV1h9dK4WxM4 Co-authored-by: Claude Fable 5.2 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docs only: states a contract the code already had and nothing said.
Ready=Falsewith reasonCreating, and conditions are replaced by type. AReadyreason a provider sets inCreateis overwritten and nothing reports it.Createreturns (it becomes the message ofSynced=False/ReconcileError) or in a condition of a type of its own.Createmust not persist the object's status itself: the value reaches the API server and is replaced within the same reconcile, so a watcher can see it flap.Found by aruba-provider-kog on rest-dynamic-controller 0.64.0, whose no-create kinds set
Ready=False/NoCreateVerbDeclaredand readCreatingonce settled. The user chose to keep the behaviour and document it.🤖 Generated with Claude Code
https://claude.ai/code/session_01NSM9VYtekkTV1h9dK4WxM4