Repository navigation
test(tailsampling): the shared snowplow upstream case in #1322's real span shape - #174
Merged
Merged
Conversation
… span shape snowplow sent the span shape from PR #1322's in-memory-exporter test: the marker snowplow.upstream.joiners sits on the shared request's CLIENT span, a child inside the starter's trace, and a joiner is an internal span tied to it only by an attribute-less link. The test now uses that shape (kind client, child of a server root, the same attributes) and asserts the trace is kept whole, root included, not just the child. Test-only; no chart change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01N8HNbDgLwRKg9uhTx5o6pn
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
snowplow sent the span shape from PR #1322's unit test, which uses an in-memory exporter with one starter and two joiners:
snowplow.upstream.joiners(int, present only when > 0) sits on the shared request's CLIENT span. That span is a child inside the starter's trace, not its root.tests/tailsampling-docker.pynow builds exactly that shape: a server rootGET /call, and a client childHTTP GETwith the same HTTP attributes plus the marker. The test also asserts the trace is kept whole, root included, not just the marked child. The joiner case is an internal span with a link and stays sampled.This is test-only; the 0.1.13 rule already matches on any span of the trace, so no chart changes. All cases pass locally.
🤖 Generated with Claude Code
https://claude.ai/code/session_01N8HNbDgLwRKg9uhTx5o6pn