Repository navigation
fix(web): stop naming every Lua-bridge emulator BizHawk - #452
Merged
Merged
Conversation
SNI's luabridge driver keeps the connector's name and protocol version ('SNI Connector', '4')
and drops the emulator the connector reports (BizHawk, Snes9x, Mesen-S), so a Lua emulator
was shown as 'BizHawk 4'. Show the kind, 'Lua emulator', without the protocol version.
Contributor
🔍 CI Results
📊 Test Coverage
✅ All checks passed! Updated at 2026-10-30T12:15:20.791Z |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Any emulator on SNI's Lua bridge (e.g. Mesen via MesenSConnector.lua) showed as "BizHawk 4" in the autotracking status and dialog.
SNI's luabridge driver (devices/snes/drivers/luabridge/device.go, v0.0.103) reads the connector's
Version|<client>|<protocol>|<emulator>reply but keeps only the first two fields ("SNI Connector", "4"); the emulator name is never exposed to clients, and the "4" is the connector protocol version. So the status now says "Lua emulator" ("the Lua emulator" in the headline) and drops that version.Verification: new status spec cases (fail before); lint, typecheck, check:docs and test:coverage exit 0. No dialog text beyond the device name changed, so no e2e run.