Repository navigation
fix(web): fold the secondary toolbar actions to icons before every label - #313
Merged
Merged
Conversation
The first fold dropped all labels at once, so adding Share left a bare icon bar at 1440 px. Export, Import, Share, Stream view and Shortcuts now fold first; Mode, New game and Autotracking keep their labels until the whole bar must go to icons. Super Metroid and SMZ3 follow the same order.
Contributor
🔍 CI Results
📊 Test Coverage
✅ All checks passed! Updated at 2026-10-20T19:55:40.673Z |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At 1440 px the toolbar fell to all icons since Share joined it, leaving ~550 px empty. A new
secondary-iconsform folds Export, Import, Share, Stream view and Shortcuts first; Mode, New game, Autotracking, the map layout and big keys keep their labels. Super Metroid and SMZ3 follow the same order.ALttPR forms now: labels from ~1530 px, secondary-icons ~1130-1520, icons ~860-1130, More below. Checked with unit specs, screenshots at 390/820/1280/1440/1920 (SM and SMZ3 too), lint, types, coverage, build and the e2e suite.