Add a check for namespace existence in kpt live apply#4653
Merged
efiacor merged 2 commits intoJul 22, 2026
Conversation
…s where the inventory namespace does not exist" Signed-off-by: Oisin Johnston <oisin.johnston@ericsson.com>
OisinJohnston2005
requested review from
efiacor,
kispaljr,
liamfallon and
mozesl-nokia
as code owners
July 20, 2026 15:33
dosubot
Bot
added
the
size:M
✅ Deploy Preview for kptdocs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Catalin-Stratulat-Ericsson
left a comment
Catalin-Stratulat-Ericsson
left a comment
Contributor
There was a problem hiding this comment.
looks good just 2 minor comments
mozesl-nokia
previously approved these changes
Jul 21, 2026
Signed-off-by: Oisin Johnston <oisin.johnston@ericsson.com>
mozesl-nokia
approved these changes
Jul 21, 2026
Catalin-Stratulat-Ericsson
approved these changes
Jul 22, 2026
Catalin-Stratulat-Ericsson
left a comment
Catalin-Stratulat-Ericsson
left a comment
Contributor
There was a problem hiding this comment.
looks good 👍
aravindtga
pushed a commit
to Nordix/kpt
that referenced
this pull request
Jul 22, 2026
* Fixed kptdev#2123 "kpt live with dry-run does not recognize situations where the inventory namespace does not exist" Signed-off-by: Oisin Johnston <oisin.johnston@ericsson.com> * added tests Signed-off-by: Oisin Johnston <oisin.johnston@ericsson.com> --------- Signed-off-by: Oisin Johnston <oisin.johnston@ericsson.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #2123, by adding a check for the existence of the namespace in kpt live apply