Make it possible to resolve IPv6 host, add some more informative logging#29
Open
t-nel-95 wants to merge 1 commit intokowalpy:masterfrom
Open
Make it possible to resolve IPv6 host, add some more informative logging#29t-nel-95 wants to merge 1 commit intokowalpy:masterfrom
t-nel-95 wants to merge 1 commit intokowalpy:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per the title.
Notes:
If
hostis a hostname and not a literal address, it will try to resolve IPv6 first.If you want to avoid this, and explicitly use IPv4, simply resolve the hostname beforehand and pass a literal IPv4 address instead.
This was done to allow the socket to work on both python 3.12+ and python 3.13.