Skip to content

Lost of precision due to the use of float as type for degrees #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jmfermun wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Lost of precision due to the use of float as type for degrees #72

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions minmea.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,10 +262,10 @@ static inline float minmea_tofloat(const struct minmea_float *f)
}

/**
* Convert a raw coordinate to a floating point DD.DDD... value.
* Convert a raw coordinate to a double floating point DD.DDD... value.
* Returns NaN for "unknown" values.
*/
static inline float minmea_tocoord(const struct minmea_float *f)
static inline double minmea_tocoord(const struct minmea_float *f)
{
if (f->scale == 0)
return NAN;
Expand All @@ -275,7 +275,7 @@ static inline float minmea_tocoord(const struct minmea_float *f)
return NAN;
int_least32_t degrees = f->value / (f->scale * 100);
int_least32_t minutes = f->value % (f->scale * 100);
return (float) degrees + (float) minutes / (60 * f->scale);
return (double) degrees + (double) minutes / (60 * f->scale);
}

/**
Expand Down