Repository navigation
ci: test with OPA 1.20.2 only and drop OPA 1.19 - #186
Merged
Merged
Conversation
OPA 1.19 says 1 >= 100.0 is true, so ergo gives wrong verdicts on it, and a test that pins the right answer can't pass there. Every job now runs 1.20.2, the version the Kosli CLI embeds, so the separate 1.20 job goes. The README says ergo needs 1.20.1 or later, because 1.20.0 panics on 0.0 == 1.5. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves every CI job to OPA 1.20.2 and stops testing OPA 1.19.
OPA 1.19 compares some numbers wrongly:
1 >= 100.0is true, so"min_subjects": 100.0passes with one subject, andrangeandcomparecan be wrong too. The #181 review hit it again, wherex is between 100.0 and 1parses on 1.19 instead of giving "min above max". A test for that can't pass while CI runs 1.19. 1.20.2 is the version the Kosli CLI embeds..github/workflows/test.yml:test,wasm,wasm-jsandspecrun 1.20.2. The separateopa-1-20job goes, sincetestnow does what it did.test,wasmandtitlekeep their names, as the ruleset requires them.README.mdsays ergo needs 1.20.1 or later. 1.20.0 compares correctly but stops withpanic: illegal valueon0.0 == 1.5(panic: illegal value comparing a decimal zero (0.0) with any non-integral number (regression in v1.20.0) open-policy-agent/opa#9098). I ran each example on 1.19.0, 1.20.0, 1.20.1 and 1.20.2.AGENTS.md,CONTRIBUTING.md, and the site'sopaVersionand bakery page name 1.20. The site files aresite:, but they only say which OPA version ergo needs, so they go with this change.Checks run here with OPA 1.20.2: every check in
AGENTS.md, coverage, the Wasm tests in Docker, and the Wasm JS runtime script (1009 pass, 10.5 MB).🤖 Generated with Claude Code