Repository navigation
docs: list the spec in AGENTS.md and say to update it with behaviour - #184
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The checks to run before a change is done now include check_rules.py and the schema script, run in a virtual environment because Homebrew's Python refuses pip install outside one. The docs section says to update the schemas when a policy or report changes shape, and that spec_test.rego only catches behaviour a case covers. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the review of #178.
AGENTS.mdhad thespec:commit area but nothing else about the spec.spec/andspec_test.rego.specjob from ci: check the spec's rules and schemas #183, and addsspec/check_rules.pyand.github/spec-schemas.pyto the checks to run before a change is done. The schema script runs in a virtual environment outside the repo, because Homebrew's Python refusespip installoutside one (externally-managed-environment).spec/, the schemas when a policy or report changes shape, andREFERENCE.md. Acore:change that does so stayscore:.I ran every command in the checks list from the repo root on this branch, which has
mainmerged in.opa testpasses 997/997,regalfinds no violations,check_rules.pyexits 0, and the schema script prints294 cases, 0 problems.🤖 Generated with Claude Code